Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating bamarni/composer-bin-plugin (v1.2.0 => v1.3.0) #34919

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Mar 29, 2019

Description

composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 0 installs, 2 updates, 0 removals
  - Updating bamarni/composer-bin-plugin (v1.2.0 => v1.3.0): Downloading (100%)         

Release notes: https://github.com/bamarni/composer-bin-plugin/releases/tag/v1.3.0

There are a couple of bugfixes for different edge cases in composer.json files, so this is useful to have so we don't accidentally come across the edge cases.

Motivation and Context

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #34919 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34919   +/-   ##
=========================================
  Coverage     65.34%   65.34%           
  Complexity    18492    18492           
=========================================
  Files          1208     1208           
  Lines         69983    69983           
  Branches       1280     1280           
=========================================
  Hits          45733    45733           
  Misses        23878    23878           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.76% <ø> (ø) 18492 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78c56b5...95195a4. Read the comment docs.

@phil-davis
Copy link
Contributor Author

phil-davis commented Mar 29, 2019

Note: this is for core. When "somebody" touches apps next (e.g. for PHPUnit6, common Makefiles changes, or?...) then they can do the same composer update in each app. But there is no rush for that - the fixes in 1.3.0 are not directly effecting us.

@phil-davis phil-davis merged commit 537b434 into master Mar 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the composer-bin-plugin-1.3 branch March 29, 2019 04:27
@phil-davis
Copy link
Contributor Author

Backport stable10 #34920

@lock lock bot locked as resolved and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants