[stable10] remove deprecated owncloud 8.0.0 calls

[phil-davis]

Backport #32062

Only ownbrander still has these OCP\Config uses. See comment #32062 (comment) in master PR.

These were deprecated a long way back, so we should be OK to release the removal in ownCloud 10.* - 2 major versions later. ?

[codecov]

Codecov Report

Merging #34927 into stable10 will increase coverage by 0.01%.
The diff coverage is 66.66%.

@@              Coverage Diff               @@
##             stable10   #34927      +/-   ##
==============================================
+ Coverage       64.22%   64.24%   +0.01%     
+ Complexity      19905    19895      -10     
==============================================
  Files            1277     1276       -1     
  Lines           76277    76246      -31     
  Branches         1292     1292              
==============================================
- Hits            48992    48983       -9     
+ Misses          26906    26884      -22     
  Partials          379      379

Flag	Coverage Δ	Complexity Δ
#javascript	53.2% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	65.41% <66.66%> (+0.01%)	19895 <0> (-10)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
apps/files/templates/simplelist.php	0% <ø> (ø)	0 <0> (ø)	⬇️
lib/public/Template.php	0% <ø> (ø)	7 <0> (ø)	⬇️
core/js/config.php	0% <0%> (ø)	0 <0> (ø)	⬇️
lib/private/Preview/Office.php	0% <0%> (ø)	14 <0> (ø)	⬇️
public.php	0% <0%> (ø)	0 <0> (ø)	⬇️
lib/private/Files/Cache/Scanner.php	86.6% <100%> (ø)	115 <0> (ø)	⬇️
lib/private/legacy/util.php	69.88% <100%> (ø)	241 <0> (ø)	⬇️
apps/files_versions/lib/Storage.php	72.39% <100%> (ø)	95 <0> (ø)	⬇️
lib/private/Share/Share.php	71.2% <75%> (ø)	507 <0> (ø)	⬇️
apps/files_trashbin/lib/Expiration.php	98.27% <0%> (+1.72%)	29% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32437a3...49c50a3. Read the comment docs.

[codecov]

Codecov Report

Merging #34927 into stable10 will increase coverage by 0.01%.
The diff coverage is 66.66%.

@@              Coverage Diff               @@
##             stable10   #34927      +/-   ##
==============================================
+ Coverage       64.22%   64.24%   +0.01%     
+ Complexity      19905    19895      -10     
==============================================
  Files            1277     1276       -1     
  Lines           76277    76246      -31     
  Branches         1292     1292              
==============================================
- Hits            48992    48983       -9     
+ Misses          26906    26884      -22     
  Partials          379      379

Flag	Coverage Δ	Complexity Δ
#javascript	53.2% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	65.41% <66.66%> (+0.01%)	19895 <0> (-10)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
apps/files/templates/simplelist.php	0% <ø> (ø)	0 <0> (ø)	⬇️
lib/public/Template.php	0% <ø> (ø)	7 <0> (ø)	⬇️
core/js/config.php	0% <0%> (ø)	0 <0> (ø)	⬇️
lib/private/Preview/Office.php	0% <0%> (ø)	14 <0> (ø)	⬇️
public.php	0% <0%> (ø)	0 <0> (ø)	⬇️
lib/private/Files/Cache/Scanner.php	86.6% <100%> (ø)	115 <0> (ø)	⬇️
lib/private/legacy/util.php	69.88% <100%> (ø)	241 <0> (ø)	⬇️
apps/files_versions/lib/Storage.php	72.39% <100%> (ø)	95 <0> (ø)	⬇️
lib/private/Share/Share.php	71.2% <75%> (ø)	507 <0> (ø)	⬇️
apps/files_trashbin/lib/Expiration.php	98.27% <0%> (+1.72%)	29% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32437a3...49c50a3. Read the comment docs.

[codecov]

Codecov Report

Merging #34927 into stable10 will increase coverage by 0.01%.
The diff coverage is 66.66%.

@@              Coverage Diff               @@
##             stable10   #34927      +/-   ##
==============================================
+ Coverage       64.22%   64.24%   +0.01%     
+ Complexity      19905    19895      -10     
==============================================
  Files            1277     1276       -1     
  Lines           76277    76246      -31     
  Branches         1292     1292              
==============================================
- Hits            48992    48983       -9     
+ Misses          26906    26884      -22     
  Partials          379      379

Flag	Coverage Δ	Complexity Δ
#javascript	53.2% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	65.41% <66.66%> (+0.01%)	19895 <0> (-10)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
apps/files/templates/simplelist.php	0% <ø> (ø)	0 <0> (ø)	⬇️
lib/public/Template.php	0% <ø> (ø)	7 <0> (ø)	⬇️
core/js/config.php	0% <0%> (ø)	0 <0> (ø)	⬇️
lib/private/Preview/Office.php	0% <0%> (ø)	14 <0> (ø)	⬇️
public.php	0% <0%> (ø)	0 <0> (ø)	⬇️
lib/private/Files/Cache/Scanner.php	86.6% <100%> (ø)	115 <0> (ø)	⬇️
lib/private/legacy/util.php	69.88% <100%> (ø)	241 <0> (ø)	⬇️
apps/files_versions/lib/Storage.php	72.39% <100%> (ø)	95 <0> (ø)	⬇️
lib/private/Share/Share.php	71.2% <75%> (ø)	507 <0> (ø)	⬇️
apps/files_trashbin/lib/Expiration.php	98.27% <0%> (+1.72%)	29% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32437a3...49c50a3. Read the comment docs.

[PVince81]

@jvillafanez FYI

[PVince81]

👍

[ltning]

This breaks Rainloop, which we have dozens of users depending on. This kind of breakage is unacceptable. Rainloop was installed from the Market app, and I expect very clear and up-front warnings if existing_apps that are endorsed in the market are broken as a result of a stable/required update.

[phil-davis]

The master branch of rainloop-webmail https://github.com/RainLoop/rainloop-webmail/blob/master/build/owncloud/rainloop-app/appinfo/info.xml has:

<owncloud min-version="6" max-version="9.2" />

So as far as I can see the app has never yet been working with any ownCloud 10.* version.
But the marketplace says "tested for ownCloud 9.1.0 - 10.0.0". I must be missing something, because max-version in the source repo would prevent it being installed on ownCloud 10.0.0.

Oh, when I look in the downloaded rainloop-5.1.0.tar.gz there is an info.xml with:

<owncloud min-version="9.1" max-version="10.0"/>

That must have come from somewhere else. So it will install on ownCloud 10.0.* but will not install on 10.1.* or 10.2.* anyway.

There are quite a lot of recent commits in the app's repo, but no recent releases in the marketplace https://marketplace.owncloud.com/apps/rainloop

The changelog for 10.2.0 https://github.com/owncloud/core/blob/stable10/CHANGELOG.md does mention this PR. But yes, ideally the deprecated things would have been released in 10.0.0 where people would go looking for that sort of change

What to do now?

Maybe Rainloop can make a release that supports ownCloud 10.2 ?
Or?

@DeepDiver1975 @micbar