Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-10.2.1] Fix invalid token on pw reset #35607

Merged
merged 1 commit into from
Jun 20, 2019

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Jun 19, 2019

Description

Backport to Release-10.2.1 branch of #35595

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@micbar micbar self-assigned this Jun 19, 2019
@micbar micbar added Type:Bug p2-high Escalation, on top of current planning, release blocker 3 - To Review labels Jun 19, 2019
@micbar micbar added this to the development milestone Jun 19, 2019
@micbar micbar force-pushed the release10.2.1-fix-invalid-token branch from 8eab4d2 to b1661b8 Compare June 19, 2019 17:29
@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #35607 into release-10.2.1 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             release-10.2.1   #35607      +/-   ##
====================================================
+ Coverage             64.39%   64.39%   +<.01%     
- Complexity            20145    20149       +4     
====================================================
  Files                  1286     1286              
  Lines                 77087    77096       +9     
  Branches               1308     1308              
====================================================
+ Hits                  49640    49649       +9     
  Misses                27063    27063              
  Partials                384      384
Flag Coverage Δ Complexity Δ
#javascript 53.66% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.53% <100%> (ø) 20149 <0> (+4) ⬆️
Impacted Files Coverage Δ Complexity Δ
core/Controller/LostController.php 89.18% <100%> (+0.69%) 37 <0> (+4) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d1d126...b1661b8. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #35607 into release-10.2.1 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             release-10.2.1   #35607      +/-   ##
====================================================
+ Coverage             64.39%   64.39%   +<.01%     
- Complexity            20145    20149       +4     
====================================================
  Files                  1286     1286              
  Lines                 77087    77096       +9     
  Branches               1308     1308              
====================================================
+ Hits                  49640    49649       +9     
  Misses                27063    27063              
  Partials                384      384
Flag Coverage Δ Complexity Δ
#javascript 53.66% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.53% <100%> (ø) 20149 <0> (+4) ⬆️
Impacted Files Coverage Δ Complexity Δ
core/Controller/LostController.php 89.18% <100%> (+0.69%) 37 <0> (+4) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d1d126...b1661b8. Read the comment docs.

Copy link
Contributor

@patrickjahns patrickjahns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickjahns patrickjahns merged commit 7510419 into release-10.2.1 Jun 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the release10.2.1-fix-invalid-token branch June 20, 2019 22:18
@phil-davis phil-davis mentioned this pull request Jun 21, 2019
11 tasks
@davitol davitol mentioned this pull request Jun 25, 2019
11 tasks
@patrickjahns patrickjahns modified the milestones: development, QA Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - To release p2-high Escalation, on top of current planning, release blocker Type:Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants