Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Acceptance test to assert the sharer can unshare and the receiver no longer sees the federated share #37090

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

jasson99
Copy link
Contributor

@jasson99 jasson99 commented Mar 6, 2020

Description

Acceptance test to assert the sharer can unshare and the receiver no longer sees the federated share

Related Issue

#34149

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@haribhandari07 haribhandari07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasson99 jasson99 requested a review from phil-davis March 6, 2020 10:43
@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #37090 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37090   +/-   ##
=========================================
  Coverage     64.76%   64.76%           
  Complexity    19136    19136           
=========================================
  Files          1270     1270           
  Lines         74915    74915           
  Branches       1328     1328           
=========================================
  Hits          48516    48516           
  Misses        26009    26009           
  Partials        390      390           
Flag Coverage Δ Complexity Δ
#javascript 54.18% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.93% <ø> (ø) 19136.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3775541...ec5d58f. Read the comment docs.

@phil-davis
Copy link
Contributor

@jasson99 more conflicts. We can probably just get 1 of these PRs merged at a time...

@jasson99 jasson99 force-pushed the sharerUnsharesFederatedShare branch from 2d307b1 to b99fe37 Compare March 6, 2020 11:02
@kiranparajuli589
Copy link
Contributor

LGTM 👍

@phil-davis phil-davis force-pushed the sharerUnsharesFederatedShare branch from b99fe37 to ec5d58f Compare March 6, 2020 12:24
@phil-davis phil-davis merged commit 5d9ae00 into master Mar 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the sharerUnsharesFederatedShare branch March 6, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants