Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] Trigger CI #38895

Closed
wants to merge 1 commit into from
Closed

Conversation

phil-davis
Copy link
Contributor

To check how notifications PR owncloud/notifications#342 has effected core tests.

To check how notifications PR owncloud/notifications#342 has effected core tests.
@phil-davis phil-davis self-assigned this Jun 26, 2021
@phil-davis
Copy link
Contributor Author

phil-davis commented Jun 26, 2021

In PR #38894

https://drone.owncloud.com/owncloud/core/30811/105/13

 Scenario: share to user sends notification                                                            # /drone/src/tests/acceptance/features/apiSharingNotificationsToShares/sharingNotifications.feature:25
    Given parameter "shareapi_auto_accept_share" of app "core" has been set to "no"                     # AppConfigurationContext::serverParameterHasBeenSetTo()
    And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "/textfile0.txt"                # FeatureContext::userHasUploadedAFileTo()
    When user "Alice" shares folder "/PARENT" with user "Brian" using the sharing API                   # FeatureContext::userSharesFileWithUserUsingTheSharingApi()
    And user "Alice" shares file "/textfile0.txt" with user "Brian" using the sharing API               # FeatureContext::userSharesFileWithUserUsingTheSharingApi()
    Then user "Brian" should have 2 notifications                                                       # NotificationsCoreContext::userNumNotifications()
    And the last notification of user "Brian" should match these regular expressions about user "Alice" # NotificationsCoreContext::matchNotificationRegularExpression()
      | key         | regex                                            |
      | app         | /^files_sharing$/                                |
      | subject     | /^"%displayname%" shared "PARENT" with you$/     |
      | message     | /^"%displayname%" invited you to view "PARENT"$/ |
      | link        | /^(\/index\.php)?\/f\/(\d+)$/                    |
      | object_type | /^local_share$/                                  |
      '/^(\/index\.php)?\/f\/(\d+)$/' does not match 'https://server/f/2147483661'
      Failed asserting that false is not false.

I suspect that notifications PR owncloud/notifications#342 has changed the link reported in a notification.

Investigating here...

@phil-davis
Copy link
Contributor Author

https://drone.owncloud.com/owncloud/core/30812/104/13

  Scenario: share to user sends notification                                                            # /drone/src/tests/acceptance/features/apiSharingNotificationsToRoot/sharingNotifications.feature:24
    Given parameter "shareapi_auto_accept_share" of app "core" has been set to "no"                     # AppConfigurationContext::serverParameterHasBeenSetTo()
    And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "/textfile0.txt"                # FeatureContext::userHasUploadedAFileTo()
    When user "Alice" shares folder "/PARENT" with user "Brian" using the sharing API                   # FeatureContext::userSharesFileWithUserUsingTheSharingApi()
    And user "Alice" shares file "/textfile0.txt" with user "Brian" using the sharing API               # FeatureContext::userSharesFileWithUserUsingTheSharingApi()
    Then user "Brian" should have 2 notifications                                                       # NotificationsCoreContext::userNumNotifications()
    And the last notification of user "Brian" should match these regular expressions about user "Alice" # NotificationsCoreContext::matchNotificationRegularExpression()
      | key         | regex                                            |
      | app         | /^files_sharing$/                                |
      | subject     | /^"%displayname%" shared "PARENT" with you$/     |
      | message     | /^"%displayname%" invited you to view "PARENT"$/ |
      | link        | /^(\/index\.php)?\/f\/(\d+)$/                    |
      | object_type | /^local_share$/                                  |
      '/^(\/index\.php)?\/f\/(\d+)$/' does not match 'https://server/f/2147483661'
      Failed asserting that false is not false.

  Scenario: share to group sends notification to every member                                           # /drone/src/tests/acceptance/features/apiSharingNotificationsToRoot/sharingNotifications.feature:38
    Given parameter "shareapi_auto_accept_share" of app "core" has been set to "no"                     # AppConfigurationContext::serverParameterHasBeenSetTo()
    And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "/textfile0.txt"                # FeatureContext::userHasUploadedAFileTo()
    When user "Alice" shares folder "/PARENT" with group "grp1" using the sharing API                   # FeatureContext::userSharesFileWithGroupUsingTheSharingApi()
    And user "Alice" shares file "/textfile0.txt" with group "grp1" using the sharing API               # FeatureContext::userSharesFileWithGroupUsingTheSharingApi()
    Then user "Brian" should have 2 notifications                                                       # NotificationsCoreContext::userNumNotifications()
    And the last notification of user "Brian" should match these regular expressions about user "Alice" # NotificationsCoreContext::matchNotificationRegularExpression()
      | key         | regex                                            |
      | app         | /^files_sharing$/                                |
      | subject     | /^"%displayname%" shared "PARENT" with you$/     |
      | message     | /^"%displayname%" invited you to view "PARENT"$/ |
      | link        | /^(\/index\.php)?\/f\/(\d+)$/                    |
      | object_type | /^local_share$/                                  |
      '/^(\/index\.php)?\/f\/(\d+)$/' does not match 'https://server/f/2147483675'
      Failed asserting that false is not false.
    And user "Carol" should have 2 notifications                                                        # NotificationsCoreContext::userNumNotifications()
    And the last notification of user "Carol" should match these regular expressions about user "Alice" # NotificationsCoreContext::matchNotificationRegularExpression()
      | key         | regex                                            |
      | app         | /^files_sharing$/                                |
      | subject     | /^"%displayname%" shared "PARENT" with you$/     |
      | message     | /^"%displayname%" invited you to view "PARENT"$/ |
      | link        | /^(\/index\.php)?\/f\/(\d+)$/                    |
      | object_type | /^local_share$/                                  |
...
runsh: Total unexpected failed scenarios throughout the test run:
apiSharingNotificationsToRoot/sharingNotifications.feature:24
apiSharingNotificationsToRoot/sharingNotifications.feature:38
apiSharingNotificationsToRoot/sharingNotifications.feature:75
apiSharingNotificationsToRoot/sharingNotifications.feature:102

And similar in https://drone.owncloud.com/owncloud/core/30812/105/13

runsh: Total unexpected failed scenarios throughout the test run:
apiSharingNotificationsToShares/sharingNotifications.feature:25
apiSharingNotificationsToShares/sharingNotifications.feature:39
apiSharingNotificationsToShares/sharingNotifications.feature:64
apiSharingNotificationsToShares/sharingNotifications.feature:91

I will make a PR to adjust the tests...

@phil-davis
Copy link
Contributor Author

Fixed by #38896

@phil-davis phil-davis closed this Jun 26, 2021
@phil-davis phil-davis deleted the phil-davis-patch-2 branch June 26, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant