Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Movie preview - use frame after 5 seconds #5882

Merged
merged 3 commits into from
Nov 22, 2013
Merged

Conversation

MorrisJobke
Copy link
Contributor

please review @karlitschek @DeepDiver1975 @schiesbn @georgehrke @Kondou-ger @PVince81

superseeds #5739 because #5767 was merged.

Fixes #5738

@Niduroki
Copy link
Member

Still wondering, what we should do, if the video is smaller than 5 seconds.

ffmpeg will output an empty file. I'd say we should check for this and display the default-mimetype-file in that case.

@ghost ghost assigned MorrisJobke Nov 15, 2013
@ghost
Copy link

ghost commented Nov 15, 2013

Test passed.
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/2011/

@DeepDiver1975
Copy link
Member

I'd say we should check for this and display the default-mimetype-file in that case.

sounds reasonable - can you give that a try? THX

@PVince81
Copy link
Contributor

I guess it's not possible to get the video length / total frames count from the header using libs ? (might be overkill, yes...)

@MorrisJobke
Copy link
Contributor Author

@Kondou-ger Can you take care of the mentioned improvement?

@DeepDiver1975
Copy link
Member

bildschirmfoto vom 2013-11-22 12 08 46

bildschirmfoto vom 2013-11-22 12 09 32

@DeepDiver1975
Copy link
Member

In cases the video doesn't contain enough data to generate the thumbnails the mime type icon was displayed.
I'd consider this a reasonable approach.

A more advanced approach might be to use avconv possibility to export a series of frames and select the first being not bla{n|c}k - but this is something we can implement in a later stage.

👍 for me for this pull request.

@georgehrke
Copy link
Contributor

👍

@ghost
Copy link

ghost commented Nov 22, 2013

Test failed.
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/2086/

@DeepDiver1975
Copy link
Member

failing unit test is unrelated - needs to be fixed in master

DeepDiver1975 added a commit that referenced this pull request Nov 22, 2013
Movie preview - use frame after 5 seconds
@DeepDiver1975 DeepDiver1975 merged commit c05177b into master Nov 22, 2013
@DeepDiver1975 DeepDiver1975 deleted the preview-movie-5s branch November 22, 2013 12:27
@MorrisJobke MorrisJobke removed their assignment Oct 5, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video thumbnail: don't use first frame - most probably a black screen
5 participants