-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Movie preview - use frame after 5 seconds #5882
Conversation
Still wondering, what we should do, if the video is smaller than 5 seconds. ffmpeg will output an empty file. I'd say we should check for this and display the default-mimetype-file in that case. |
Test passed. |
sounds reasonable - can you give that a try? THX |
I guess it's not possible to get the video length / total frames count from the header using libs ? (might be overkill, yes...) |
@Kondou-ger Can you take care of the mentioned improvement? |
…ion -vsync 1 can heal that
in some cases 1MB was no enough to generate thumbnail
In cases the video doesn't contain enough data to generate the thumbnails the mime type icon was displayed. A more advanced approach might be to use avconv possibility to export a series of frames and select the first being not bla{n|c}k - but this is something we can implement in a later stage. 👍 for me for this pull request. |
👍 |
Test failed. |
failing unit test is unrelated - needs to be fixed in master |
Movie preview - use frame after 5 seconds
please review @karlitschek @DeepDiver1975 @schiesbn @georgehrke @Kondou-ger @PVince81
superseeds #5739 because #5767 was merged.
Fixes #5738