Makes #app-navigation a part of app management.

[raghunayyar]

A fix for #7799 for App Management in Core. Please check.
@jancborchardt @owncloud/designers

[PVince81]

Please compare before and after when making CSS changes.
For this you can simply open two browser tabs.
Check out master and open app management in the first tab.
Then check out your branch and open it in the second tab.
Then you can switch from one tab to the other and compare to see if it looks the same.

I just did that and saw that the CSS is broken on your branch:

• selected app isn't highlighted any more
• app names isn't bold any more

[raghunayyar]

@PVince81 fixed

[PVince81]

Before:

After:

The highlight is still missing and the paddings seem to be messed up.

Did you try the comparing technique I suggested ?

[raghunayyar]

From IRC chat with @PVince81, @jancborchardt making how it is inside requires a lot of tampering with the #app-navigation on the setting.css page with the colors and the transitions. Should I go ahead? Including #app-navigation and giving up on #leftcontent is anyway changing JS and CSS as you can see in the PR.

[PVince81]

I think we should fix the layout because it looks broken.
@jancborchardt does #app-navigation provide a new look that is different than the original one from the app management ? Or should that page be fixed to look exactly like before, but using the new CSS class ?

[jancborchardt]

Mainly it should use the new #app-navigation styles. If something on those is off, or there needs to be extra classes, please adjust that and add it to the core/css/apps.css

[raghunayyar]

I am more happy the styles are handled on the leftcontent than app-navigation, so will update core/css/apps.css for you guys to have a look. Thx.

[jancborchardt]

@raghunayyar if you change the core app styles, you also need to test with all apps which use those. News, Notes, Contacts, new Calendar (more?) cc @jbtbnl @tanghus @Raydiation @cosenal @georgehrke

One problem I see right now is that we should not use bold styles to highlight the selected item – because that is used for »unread« or »new« in the News app for example (and will be for other messaging apps like Mail and Chat).

[raghunayyar]

One problem I see right now is that we should not use bold styles to highlight the selected item – because that is used for »unread« or »new« in the News app for example (and will be for other messaging apps like Mail and Chat).

@jancborchardt I guess it is fixed, only active items are bold. Selected item just have change in background color.

[jancborchardt]

@raghunayyar active items should not be bold either. Bolding is reserved for entries where something is new.

[raghunayyar]

@jancborchardt done.

[MorrisJobke]

I merged come CSS rules for the same background color.

I also like to have the .active to be #ddd (instead of #eee) and the .selected and :hover to be #ccc (instead of #ddd).

That makes a better differentiation between selected, active and non-active element.

@owncloud/designers opinion?

[ghost]

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/3955/

[raghunayyar]

I like. :)

[jbtbnl]

I like it too :)

[MorrisJobke]

I added the change

[scrutinizer-notifier]

A new inspection was created.

[raghunayyar]

I am pushing this in as soon as the build goes green. 👍

[ghost]

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/3979/

[MorrisJobke]

@jbtbnl Do you reviewed this? Then maybe add a 👍 for the review process ;)

[jbtbnl]

@MorrisJobke actually I checked the new styles with the contacts app, where it works great, because now there is a difference between the selected element color and the hovered element color.

In app management the issue is that the active+selected elements have the same color as the active+hover element. This makes that the hovered element is not easily distinguishable in app management when it is adjacent to the active+selected element.

I believe we should get rid of the 'active' class for the activated apps and provide a different kind of distinction, for example prepend icon-checkmark.

cc @jancborchardt

Adding yet another gradient level to fix the above mentioned issue is not desirable as it will become confusing what they all represent.

[MorrisJobke]

@jbtbnl I think we should not focus on the app management, as there were plans to move the view of the apps to a grid view. So I'm fine with the current version.

[jbtbnl]

@MorrisJobke OK, is there already an issue / pull request for that?

[MorrisJobke]

@jbtbnl I thought @jancborchardt opened a design proposal.

[raghunayyar]

Ok. What do we do with this? cc @MorrisJobke @jbtbnl @jancborchardt

[jbtbnl]

@MorrisJobke found it: #1924

@raghunayyar this pull request is still useful

[MorrisJobke]

@jbtbnl Sorry I pasted the wrong :(

I will merge this now. All other issue can be adressed in separate PRs