Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two Factor Auth #4049

Closed
voroyam opened this issue Sep 17, 2021 · 6 comments · Fixed by #4209
Closed

Two Factor Auth #4049

voroyam opened this issue Sep 17, 2021 · 6 comments · Fixed by #4209

Comments

@voroyam
Copy link
Contributor

voroyam commented Sep 17, 2021

WHAT Needs to be Documented?

there seems to be more commands that are not covered on the page for the two factor auth here:

https://doc.owncloud.com/server/10.7/admin_manual/configuration/server/occ_commands/app_commands/2fa_commands.html

If I look at my command line output I see:

 twofactorauth:disable
      twofactorauth:enable
      twofactor_totp:delete-redundant-secret
      twofactor_totp:set-secret-verification-status

Maybe the bottom 2 commands are not related to the app itself, but I haven't seen those and don't know what they do.

WHERE Does This Need To Be Documented (Link)?

https://doc.owncloud.com/server/10.7/admin_manual/configuration/server/occ_commands/app_commands/2fa_commands.html

I am confused we have no entry for this app in our security section of the documentation. Maybe there is not much to write about but I would expect something important to users or customers documented. How to enable, how to use, how to disable and how to troubleshoot.

Screenshot 2021-09-17 at 14 36 50

WHY Should This Change Be Made?

to give users and customers a better understanding about the app

@mmattel
Copy link
Contributor

mmattel commented Sep 17, 2021

Thanks for the heads up @voroyam 👍
Nobody has told us about any missing pieces, neither on a description base nor on occ commands.
We are no experts in this topic and need help to fix this. Support is very welcomed.

@voroyam
Copy link
Contributor Author

voroyam commented Sep 18, 2021

You are the expert, tell me how I can help.

The text, how it is written right now, is not correct as far as I can see it, the commands have to be added as well, in my view. Lastly I would add a page in the security section of the server docs describing the app and linking to the occ command page.

I can correct / add the existing text describing the app and you can improve the writing.

The occ commands I posted in my original post, but I can add text what they do.

@EParzefall
Copy link
Contributor

Yes, please provide the necessary information @voroyam .

@voroyam
Copy link
Contributor Author

voroyam commented Oct 28, 2021

I feel like I did.

  1. occ commands should be added to the existing page.

  2. Explanation what they do should be added to the existing page.

  3. Page should be moved in to the security section.

Regarding the second point - this is your job to find out imho.

But I took the time and researched, the first command is described here:

owncloud/twofactor_totp#133

The description is short but better than nothing I guess.

Second command was harder to find, most can be found in the comment form Vincent:

owncloud/twofactor_totp#46 (comment)

and this comment as well:

owncloud/twofactor_totp#46 (comment)

@mmattel
Copy link
Contributor

mmattel commented Nov 3, 2021

@voroyam I have taken a closer look in that, but things are more complicated as they appear. I have identified the proper way to implement it and will do this it asap.

@voroyam
Copy link
Contributor Author

voroyam commented Nov 3, 2021

awesome. The doc team meeting is on Thursday at 11? If I wanted to join, I would need to know when :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants