Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command for deleting redundant secrets #133

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

boyrazs15
Copy link
Contributor

Resolves #110

This PR adds a command for deleting non-existing users secret.

@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #133 into master will increase coverage by 3.18%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #133      +/-   ##
============================================
+ Coverage     64.68%   67.87%   +3.18%     
- Complexity       61       67       +6     
============================================
  Files            13       14       +1     
  Lines           252      277      +25     
============================================
+ Hits            163      188      +25     
  Misses           89       89
Impacted Files Coverage Δ Complexity Δ
lib/Db/TotpSecretMapper.php 100% <100%> (ø) 6 <1> (+1) ⬆️
lib/Command/DeleteRedundantSecretsCommand.php 100% <100%> (ø) 5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47aff5b...c1efce3. Read the comment docs.

Copy link
Contributor

@karakayasemi karakayasemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @boyrazs15 Thank you for contribution.

@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #133 into master will increase coverage by 3.18%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #133      +/-   ##
============================================
+ Coverage     64.68%   67.87%   +3.18%     
- Complexity       61       67       +6     
============================================
  Files            13       14       +1     
  Lines           252      277      +25     
============================================
+ Hits            163      188      +25     
  Misses           89       89
Impacted Files Coverage Δ Complexity Δ
lib/Db/TotpSecretMapper.php 100% <100%> (ø) 6 <1> (+1) ⬆️
lib/Command/DeleteRedundantSecretsCommand.php 100% <100%> (ø) 5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47aff5b...c1efce3. Read the comment docs.

@karakayasemi karakayasemi merged commit a1d5517 into owncloud:master Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command to clear secret of users which are deleted before totp 0.5.3
2 participants