-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OC11] Issue 284 document files:scan --group #642
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for raising the issue, @phil-davis. Looks good to me. Quick question though; would it not have been simpler to implement further CSV functionality in the options supplied to group, rather than change groups to group? For example, by surrounding fields with double-quotes, as in this example, --groups="group1",group2,group3,"group,1,2,3"
groups with and without commas in their names can be supplied to the groups
option.
Having this in the documentation also highlights the point you made last week about having master be deployed to the live documentation, and being the default view. It will be confusing for users seeing features that aren't available in their release. |
thinking that we might want to backport this change as well as long as it's not a breaking feature @phil-davis |
As I remember, other |
See comment owncloud/core#31719 (comment) - it breaks the old/existing way to type the |
That was the reason that I made the PR now. It presses the point that we should be able to merge doc changes for core master features to docs master branch, and have it "always up-to-date and ready-to-release" (oh, I hear the pigs flying overhead again ;) |
hmm right :-/ |
@phil-davis, re #642 (comment), I agree with you. That should be the case. |
On reviewing the playbook ( |
Issue #284
This change should be released with the next core major version release.
So it should be able to be merged to
docs
master
, but do not backport to any10.*
branch because it will not be released in any of those versions.