Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OC11] Issue 284 document files:scan --group #642

Merged
merged 2 commits into from
Feb 26, 2019
Merged

[OC11] Issue 284 document files:scan --group #642

merged 2 commits into from
Feb 26, 2019

Conversation

phil-davis
Copy link
Contributor

Issue #284

This change should be released with the next core major version release.

So it should be able to be merged to docs master, but do not backport to any 10.* branch because it will not be released in any of those versions.

Copy link
Contributor

@settermjd settermjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising the issue, @phil-davis. Looks good to me. Quick question though; would it not have been simpler to implement further CSV functionality in the options supplied to group, rather than change groups to group? For example, by surrounding fields with double-quotes, as in this example, --groups="group1",group2,group3,"group,1,2,3" groups with and without commas in their names can be supplied to the groups option.

@settermjd
Copy link
Contributor

Having this in the documentation also highlights the point you made last week about having master be deployed to the live documentation, and being the default view. It will be confusing for users seeing features that aren't available in their release.

@PVince81
Copy link
Contributor

thinking that we might want to backport this change as well as long as it's not a breaking feature @phil-davis

@phil-davis
Copy link
Contributor Author

phil-davis commented Feb 26, 2019

Thanks for raising the issue, @phil-davis. Looks good to me. Quick question though; would it not have been simpler to implement further CSV functionality in the options supplied to group, rather than change groups to group? For example, by surrounding fields with double-quotes, as in this example, --groups="group1",group2,group3,"group,1,2,3" groups with and without commas in their names can be supplied to the groups option.

As I remember, other occ commands already have the repeated --group way of doing it, so we kept the same system here. owncloud/core#31719 (comment)

@phil-davis
Copy link
Contributor Author

thinking that we might want to backport this change as well as long as it's not a breaking feature @phil-davis

See comment owncloud/core#31719 (comment) - it breaks the old/existing way to type the occ command for a group scan.

@phil-davis
Copy link
Contributor Author

Having this in the documentation also highlights the point you made last week about having master be deployed to the live documentation, and being the default view. It will be confusing for users seeing features that aren't available in their release.

That was the reason that I made the PR now. It presses the point that we should be able to merge doc changes for core master features to docs master branch, and have it "always up-to-date and ready-to-release" (oh, I hear the pigs flying overhead again ;)

@PVince81
Copy link
Contributor

hmm right :-/

@settermjd
Copy link
Contributor

@phil-davis, re #642 (comment), I agree with you. That should be the case.

@settermjd
Copy link
Contributor

On reviewing the playbook (site.yml) again, master's been removed, so showing features for future releases is no longer an issue.

@settermjd settermjd merged commit fae6fef into master Feb 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the issue-284 branch February 26, 2019 10:19
settermjd pushed a commit that referenced this pull request Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants