Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable search field #37

Closed
oparoz opened this issue Feb 21, 2015 · 4 comments
Closed

Disable search field #37

oparoz opened this issue Feb 21, 2015 · 4 comments
Milestone
5

Comments

@oparoz
Copy link
Contributor

oparoz commented Feb 21, 2015

The search field is not yet automatically disabled in core for apps which have not registered with the search system, see owncloud/core#11635 (comment)

We should hide that field for now since it does not work.

@jancborchardt - Feel free to voice your opinion
@oparoz
Copy link
Contributor Author

oparoz commented Feb 24, 2015

Search field is now hidden.

@oparoz oparoz closed this as completed Feb 24, 2015
@jancborchardt
Copy link
Member

It’s actually a good question how we deal with that in core for apps in general. @oparoz can you open an issue in core for that?

cc @DeepDiver1975 @butonic for reference

@oparoz
Copy link
Contributor Author

oparoz commented Feb 25, 2015

@jancborchardt - There is already something here, which is unresolved owncloud/core#11635

@jancborchardt
Copy link
Member

@oparoz no, that specific one is resolved (as I commented). Search in apps works in master. As I commented there, it would be cool if you can open a new more general issue in core. Thanks! :)

@oparoz oparoz mentioned this issue Feb 26, 2015
Closed
@oparoz oparoz added this to the 2.1 milestone Feb 28, 2015
oparoz added a commit that referenced this issue Mar 3, 2015
@oparoz
Disable search field
e0d2458 
The search field in the ownCloud templates has stopped working for apps which are not registered to search files.
See #37 for more details.
(cherry picked from commit cd563fd)
@oparoz oparoz modified the milestones: 2.0.5, 2.1 Mar 4, 2015
DeepDiver1975 added a commit that referenced this issue Jul 25, 2015
@DeepDiver1975
Merge pull request #37 from owncloud/add-travis-ci
d26e579 
adding travis-ci support - first step if pure php lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5
Development

No branches or pull requests
2 participants
@oparoz @jancborchardt