Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show spinner when home is current and home clicked #755

Closed
wants to merge 5 commits into from

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Apr 26, 2018

Ref https://github.com/owncloud/enterprise/issues/2127

  1. Open gallery
  2. Click 'home' icon
  3. See never ending spinner

@VicDeo VicDeo requested a review from tomneedham April 26, 2018 15:43
@VicDeo VicDeo force-pushed the tweak-spinner branch 2 times, most recently from b03122e to 147ea77 Compare April 26, 2018 20:58
@tomneedham
Copy link
Contributor

Resolves the issue 👍 Now will look at the builds

@tomneedham
Copy link
Contributor

Looks like a dependency collision with core Symfony\Component\Yaml

@PVince81
Copy link
Contributor

All Travis is red.

@VicDeo please resolve separately and have this PR only include "the fix".

We'll need a new release of gallery app but likely will want to have CI sorted out by then, cc @patrickjahns

@VicDeo
Copy link
Member Author

VicDeo commented May 28, 2018

@PVince81 it's red for over a year https://github.com/owncloud/gallery/commits/master
I already spent ~ 2 days in total resolving Travis issues for these 3 lines of js so estimates on fixing Travis are unclear.

@patrickjahns
Copy link
Contributor

patrickjahns commented May 28, 2018

The other option would be to move gallery to drone - but we would most likely need to deal with js issues there as well

@PVince81
release ticket is here: #761 - please fill in specifics (if available)

@VicDeo
Copy link
Member Author

VicDeo commented May 28, 2018

it's not a js issue. Failures are related to composer deps.

@PVince81
Copy link
Contributor

Ah ok, so there are JS tests, good to know.

How long would it take to sort out the failures / setup then ?

@VicDeo
Copy link
Member Author

VicDeo commented May 29, 2018

@PVince81 For me it's a big piece of PITA but I think it's not a big deal for a person that dealt with composer.lock before.
#738 passes the CI but has a conflicting lock file.

@tomneedham
Copy link
Contributor

solved in #760

@tomneedham tomneedham closed this Jun 21, 2018
@DeepDiver1975 DeepDiver1975 deleted the tweak-spinner branch June 21, 2018 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants