Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make verification mandatory #28

Merged
merged 1 commit into from
Aug 16, 2017
Merged

make verification mandatory #28

merged 1 commit into from
Aug 16, 2017

Conversation

karakayasemi
Copy link
Contributor

@karakayasemi karakayasemi commented Aug 13, 2017 •
edited
Loading

Implementation of #27.
Verification is now mandatory to enable second-factor.
@Helios07 @DeepDiver1975 please review

@karakayasemi karakayasemi mentioned this pull request Aug 14, 2017
Closed
Helios07
Helios07 approved these changes Aug 14, 2017
View reviewed changes
Copy link

@Helios07 Helios07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested in two different owncloud 10.0.2 installations and it worked as expected.

@karakayasemi
Copy link
Contributor Author

I tested also, all test passed. @DeepDiver1975 merge ?

@DeepDiver1975 DeepDiver1975 added this to the 0.4.4 milestone Aug 16, 2017
@DeepDiver1975 DeepDiver1975 self-assigned this Aug 16, 2017
@DeepDiver1975 DeepDiver1975 self-requested a review August 16, 2017 09:20
@DeepDiver1975 DeepDiver1975 merged commit 7a2b9d8 into owncloud:master Aug 16, 2017
@karakayasemi karakayasemi mentioned this pull request Aug 24, 2017
Closed
@karakayasemi karakayasemi deleted the mandatoryVerify branch October 2, 2017 11:17
@pmaier1 pmaier1 mentioned this pull request Jan 29, 2018
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeepDiver1975 DeepDiver1975 DeepDiver1975 approved these changes

@Helios07 Helios07 Helios07 approved these changes

Assignees

@DeepDiver1975 DeepDiver1975

Labels
None yet
Projects
None yet
Milestone
0.4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@karakayasemi @DeepDiver1975 @Helios07