Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(linter): incorrect no-loss-of-precision #656

Closed
Boshen opened this issue Jul 29, 2023 · 1 comment · Fixed by #664
Closed

bug(linter): incorrect no-loss-of-precision #656

Boshen opened this issue Jul 29, 2023 · 1 comment · Fixed by #664
Labels
A-linter Area - Linter

Comments

@Boshen
Copy link
Member

Boshen commented Jul 29, 2023

From the vscode codebase

image

cc @Devin-Yeung
@Boshen Boshen added the A-linter Area - Linter label Jul 29, 2023
@Devin-Yeung
Copy link
Contributor

Already reproduced the bug 😢 , my previous implementation highly follow the eslint's implementation, but it relied on some behavior of the toPrecision function, and it may take me some time to figure out a better solution in rust.

@Devin-Yeung Devin-Yeung mentioned this issue Jul 30, 2023
Merged
@Boshen Boshen changed the title bug(linger): incorrect no-loss-of-precision bug(linter): incorrect no-loss-of-precision Jul 31, 2023
Boshen added a commit that referenced this issue Jul 31, 2023
@Devin-Yeung @Boshen
fix(linter): fix false positives in loss-of-precision lint (#664)
ba8dbf5 
Almost rewrite the no-loss-of-precision lint, fix known false positives,
close #656

---------

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-linter Area - Linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(linter): fix false positives in loss-of-precision lint Devin-Yeung/oxc
2 participants
@Boshen @Devin-Yeung