Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

publish vscode extension #688

Closed
cijiugechu opened this issue Aug 4, 2023 · 8 comments
Closed

publish vscode extension #688

cijiugechu opened this issue Aug 4, 2023 · 8 comments
Assignees
@Boshen

Comments

@cijiugechu
Copy link
Contributor

cijiugechu commented Aug 4, 2023 •
edited
Loading

I've recently been building a vscode extension for oxc, @Boshen , if you don't mind, could I submit a PR to commit this part of the code to the repository?

Functionality implemented so far:

1. Displaying diagnostics, help messages and the range of labels

1

2. Providing quick fix

2

3. Providing commands such as restart server

3

4. debug and production builds
@Boshen
Copy link
Member

Boshen commented Aug 4, 2023

Oh wow, let's do this!

@cijiugechu cijiugechu mentioned this issue Aug 5, 2023
Merged
Boshen pushed a commit that referenced this issue Aug 6, 2023
@cijiugechu
feat: vscode extension (#690)
8a915ce 
related: #688 .
There are some unfinished things that need to be finalised by Boshen.

1. Official icon and description for the package.
2. Publishing strategy ( It's probably not a good idea to use
`package.json` as a probe to publish extension, as there's too much
vscode configuration coupled to it, a git tag like `vscode_v0.0.x` might
be worth considering ).
3. License for the extension.
@kaleidawave kaleidawave mentioned this issue Aug 25, 2023
Closed
@Boshen Boshen changed the title vscode extension publish vscode extension Aug 25, 2023
@Boshen
Copy link
Member

Boshen commented Aug 25, 2023

Code is done, I need to find the time to publish this thing :-/

@kaleidawave
Copy link
Contributor

Does this include the type checking errors/diagnostics from oxc_type_synthesis? Last time I remember that the diagnostics were separated. We should figure out how to turn EznoDiagnostic into ones produced by the linter so that the CLI reporting and everything is the same.

@roonie007
Copy link

@Boshen any updates on the publishing date ?

@Boshen
Copy link
Member

Boshen commented Sep 16, 2023

@Boshen any updates on the publishing date ?

No ETA yet.

@Vincent-liuwingsang
Copy link

need any help with this? would love to try this in vscode

@Boshen Boshen assigned Boshen and unassigned cijiugechu Oct 22, 2023
@camc314
Copy link
Contributor

camc314 commented Oct 23, 2023

need any help with this? would love to try this in vscode

you can test it out with:

cd editors/vscode
pnpm run vscode (builds server + client +packages it)

then head to vscode, command pallet "Extensions: Install from VSIX..."

find the file we just built (should be: ./oxc-vscode-0.0.1.vsix or similar and install

@Boshen
Copy link
Member

Boshen commented Oct 31, 2023

Finally!

image

@Boshen Boshen closed this as completed Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Boshen Boshen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Boshen @roonie007 @Vincent-liuwingsang @camc314 @kaleidawave @cijiugechu