Move Dendrite-specific timeseries definitions to TOML #6103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nieuwejaar
reviewed
Jul 17, 2024
There was a problem hiding this comment.
I haven't been paying attention to the larger context in which this is happening, so maybe these are obvious questions...
Give that this is a "dendrite" schema, do we really need to include "Dendrite" in every description? It seems like that would be implied from the context.
I'm not sure why all of these labels are being defined in relation to the dendrite instance reporting the stats. For switch_model, it seems like "The model of the switch being monitored" would be more relevant.
|
@Nieuwejaar Sure, it seems fine to remove the references to "Dendrite" in the descriptions. Will simplify, thanks. |
Simplify field descriptions
Nieuwejaar
reviewed
Jul 17, 2024
Nieuwejaar
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.