Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action step should prioritize the used version of rb_sys from Gemfile.lock #56

Open
alex-ross opened this issue Feb 25, 2025 · 0 comments · May be fixed by #57
Open

Action step should prioritize the used version of rb_sys from Gemfile.lock #56

alex-ross opened this issue Feb 25, 2025 · 0 comments · May be fixed by #57

Comments

@alex-ross
Copy link

I would like to ensure that when rb_sys version 0.9.110 is specified in Gemfile.lock, that version is used, even if the *.gemspec file specifies ~> 0.9.91. Since we parse Gemfile.lock in the action step, it seems appropriate to consider the version recorded there as the definitive source of truth.

The extraction of the version happens here:

rb_sys_version="$((grep rb_sys Gemfile.lock | head -n 1 | grep -oE '[0-9]+\.[0-9]+\.[0-9]+') || (gem info rb_sys --remote | grep -oE '[0-9]+\.[0-9]+\.[0-9]+') || echo "latest")"

This is my Gemfile.lock

Details

PATH
  remote: .
  specs:
    app_bridge (0.5.0)
      rb_sys (~> 0.9.91)

GEM
  remote: https://rubygems.org/
  specs:
    ast (2.4.2)
    benchmark-malloc (0.2.0)
    benchmark-perf (0.6.0)
    benchmark-trend (0.4.0)
    diff-lcs (1.5.1)
    json (2.9.1)
    language_server-protocol (3.17.0.4)
    parallel (1.26.3)
    parser (3.3.7.0)
      ast (~> 2.4.1)
      racc
    racc (1.8.1)
    rainbow (3.1.1)
    rake (13.2.1)
    rake-compiler (1.2.9)
      rake
    rake-compiler-dock (1.9.1)
    rb_sys (0.9.110)
      rake-compiler-dock (= 1.9.1)
    regexp_parser (2.10.0)
    rspec (3.13.0)
      rspec-core (~> 3.13.0)
      rspec-expectations (~> 3.13.0)
      rspec-mocks (~> 3.13.0)
    rspec-benchmark (0.6.0)
      benchmark-malloc (~> 0.2)
      benchmark-perf (~> 0.6)
      benchmark-trend (~> 0.4)
      rspec (>= 3.0)
    rspec-core (3.13.2)
      rspec-support (~> 3.13.0)
    rspec-expectations (3.13.3)
      diff-lcs (>= 1.2.0, < 2.0)
      rspec-support (~> 3.13.0)
    rspec-mocks (3.13.2)
      diff-lcs (>= 1.2.0, < 2.0)
      rspec-support (~> 3.13.0)
    rspec-support (3.13.2)
    rubocop (1.71.0)
      json (~> 2.3)
      language_server-protocol (>= 3.17.0)
      parallel (~> 1.10)
      parser (>= 3.3.0.2)
      rainbow (>= 2.2.2, < 4.0)
      regexp_parser (>= 2.9.3, < 3.0)
      rubocop-ast (>= 1.36.2, < 2.0)
      ruby-progressbar (~> 1.7)
      unicode-display_width (>= 2.4.0, < 4.0)
    rubocop-ast (1.38.0)
      parser (>= 3.3.1.0)
    ruby-progressbar (1.13.0)
    unicode-display_width (3.1.4)
      unicode-emoji (~> 4.0, >= 4.0.4)
    unicode-emoji (4.0.4)

PLATFORMS
  arm64-darwin-24
  ruby

DEPENDENCIES
  app_bridge!
  json
  rake (~> 13.0)
  rake-compiler
  rspec (~> 3.0)
  rspec-benchmark
  rubocop (~> 1.21)

BUNDLED WITH
   2.5.23

alex-ross added a commit to alex-ross/oxidize-rb-actions that referenced this issue Feb 25, 2025
@alex-ross alex-ross linked a pull request Feb 25, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant