Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To php84 v2 #4518

Closed
wants to merge 5 commits into from
Closed

To php84 v2 #4518

wants to merge 5 commits into from

Conversation

llaville
Copy link
Collaborator

Fixes #4351

Proposed Changes

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

Copy link
Contributor

github-actions bot commented Jan 17, 2025

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ API spectral 1 0 1.77s
⚠️ BASH bash-exec 6 1 0.02s
✅ BASH shellcheck 6 0 0.19s
✅ BASH shfmt 6 0 0 0.65s
✅ COPYPASTE jscpd yes no 2.76s
✅ DOCKERFILE hadolint 129 0 23.35s
✅ JSON jsonlint 20 0 0.27s
✅ JSON v8r 22 0 15.28s
⚠️ MARKDOWN markdownlint 267 0 303 22.58s
✅ MARKDOWN markdown-table-formatter 267 0 0 162.29s
⚠️ PYTHON bandit 215 66 2.49s
✅ PYTHON black 215 0 0 4.73s
✅ PYTHON flake8 215 0 1.87s
✅ PYTHON isort 215 0 0 1.05s
✅ PYTHON mypy 215 0 13.04s
✅ PYTHON pylint 215 0 17.22s
✅ PYTHON ruff 215 0 0 0.91s
✅ REPOSITORY checkov yes no 31.32s
✅ REPOSITORY git_diff yes no 0.46s
⚠️ REPOSITORY grype yes 26 12.68s
✅ REPOSITORY secretlint yes no 16.08s
✅ REPOSITORY trivy yes no 16.44s
✅ REPOSITORY trivy-sbom yes no 0.27s
⚠️ REPOSITORY trufflehog yes 1 53.34s
✅ SPELL cspell 718 0 12.66s
⚠️ SPELL lychee 349 17 39.0s
✅ XML xmllint 3 0 0 0.87s
✅ YAML prettier 160 0 0 3.57s
✅ YAML v8r 102 0 27.43s
✅ YAML yamllint 161 0 2.2s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@echoix
Copy link
Collaborator

echoix commented Jan 17, 2025

Is phive still used anywhere?

@llaville
Copy link
Collaborator Author

Is phive still used anywhere?

No more, Psalm was the last PHP linter to use it to install.

@echoix
Copy link
Collaborator

echoix commented Jan 18, 2025

Is phive still used anywhere?

No more, Psalm was the last PHP linter to use it to install.

The phar and phive installation were quite flaky at a time, ci might as well remove to fit your new installation method that doesn't use it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade PHP engine from 8.3 to 8.4
2 participants