-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verification result incorrectly reports "Pact-Rust" as verifying implementation when using Golang provider verification #499
Comments
The pact-go, and other client libraries use pact-rust under the hood via FFI. It is possible to configure the verifier with a specific name and application version, which we are actually setting in pact-go Line 43 in b407e4b
however this is not used in the verifier code in rust, which defaults to So to solve this, the pact_verifier rust code, should take into consideration, the if the |
Ahh okay, this has been addressed in the pact-rust codebase by adding a new key to the payload sent to the pact-broker related issue - pact-foundation/pact-reference#307 example payload "verifiedBy": {
"implementation": "Pact-Rust",
"version": VERIFIER_VERSION,
"clientLanguage": {
"testFramework": "TEST",
"name": "TESTER",
"version": "1.2.3"
}
} Here are the docs for the pact broker publish verification endpoint The API decorator, isn't setup to display this extra detail property :provider_name, as: :providerName, writeable: false
property :provider_version_number, as: :providerApplicationVersion, writeable: false
property :success
property :execution_date, as: :verificationDate
property :build_url, as: :buildUrl
property :test_results, as: :testResults
nested :verifiedBy do
property :verified_by_implementation, as: :implementation
property :verified_by_version, as: :version
end and would need to support the extra keys
|
Description:
When verifying a provider using our Golang implementation and submitting the results to the Pact Broker (hosted via the official Docker image), the verification metadata in the broker incorrectly shows that the pacts were verified by "Pact-Rust" (version "1.2.5"). This behavior is unexpected, as our tests use a Golang verification tool.
Inside the pactBroker log the verification is published and instead of the pact-go package with the version 2.2.0 the pact-rust package is mentioned.
The text was updated successfully, but these errors were encountered: