feat: support extended verification results #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YOU54F
force-pushed
the
feat/support_extended_verification_results
branch
from
6be0735 to
1a5fdef
Compare
Optionally the body can contain details about the Pact implementation which performed the verification, and test results, which support arbitrary json
{
"providerApplicationVersion": "1",
"success": true,
"buildUrl": "http://build-url",
"testResults": [],
"verifiedBy": {
"implementation": "Pact-Rust",
"version": "1.0.0",
"clientLanguage": {
"testFramework": "TEST",
"name": "TESTER",
"version": "1.2.3"
}
}
}
YOU54F
force-pushed
the
feat/support_extended_verification_results
branch
from
1a5fdef to
e745d3e
Compare
rholshausen
approved these changes
Feb 17, 2025
mefellows
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally the body can contain details about the Pact implementation which performed the verification, and test results, which support arbitrary json
Relates to pact-foundation/pact-go#499
Question -
Would it be better to support arbitrary fields in
clientLanguage, similar to `testResults, to better support extensibility.