Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][ENV] make i18n debugging an optional env setting #2692

Merged
merged 5 commits into from
Jul 10, 2024

Conversation

flx-sta
Copy link
Contributor

@flx-sta flx-sta commented Jun 28, 2024

What are the changes?

I've made i18n debugging an optional setting that can be changed via .env files

Why am I doing these changes?

It's spamming the console but more importantly adding noise to the test-result output (a huge object in every test)

What did change?

i18n is no longer always in debug mode but can be forced into it by changing VITE_I18N_DEBUG to the value 1

Screenshots/Videos

How to test the changes?

  1. Launch the local game as usual
  2. Check the console in the browser: no i18n output
  3. Open .env.development
  4. Change VITE_I18N_DEBUG to the value 1
  5. Restart local client
  6. Check console: it should print i18n stufff

Checklist

  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • [] Are the changes visual?

Felix Staud added 2 commits June 28, 2024 12:59
@flx-sta flx-sta added Enhancement New feature or request Miscellaneous Changes that don't fit under any other label labels Jun 28, 2024
Copy link
Contributor

@torranx torranx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@flx-sta
Copy link
Contributor Author

flx-sta commented Jul 10, 2024

@Tempo-anon can this be considered ready for merge?

@f-fsantos f-fsantos changed the base branch from main to beta July 10, 2024 17:46
@CodeTappert
Copy link
Collaborator

This should be default ON.

So we can easier see which strings did not load correctly in the console

@Tempo-anon Tempo-anon merged commit fc4b97d into pagefaultgames:beta Jul 10, 2024
5 checks passed
@flx-sta flx-sta deleted the feature/i18n-debugging branch July 10, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Miscellaneous Changes that don't fit under any other label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants