Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] Lock unlock all all at once #3153

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

Opaque02
Copy link
Collaborator

What are the changes?

A mistake was made
B 4 I go on, I want to say sorry if this is needed
Right, so there's a small chance the unlock all code made it to live
Left to chance, users in live may find the new feature?
Right this wrong and merge this PR if need be
Left out is the code that unlocks it all
Down with bugs!
Down the road, if needed, another PR will open to try and fix the unlock all functionality
Up until now, we're pretty sure this PR won't be needed, but it's good to have it just in case
Up above the world so high

This PR reverses #2967 as even though we tested as much as we could, the unlock all option made its way into live. This is here as an emergency PR in case it's needed.

Why am I doing these changes?

Even though we tested 2967 as much as we did, we didn't test the unlock all functionality on live. This is a ready to go PR specifically to delete the changes from 2967 in case the unlock all option is available on live.

What did change?

I removed all the new code from 2967 except the Utils.isBeta constant

Screenshots/Videos

This is the menu before the change:
image

This is the menu after the change:
image

How to test the changes?

Download the branch and see if you can unlock all items in any of the ways available on beta

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

…all functionality but keeps the isBeta utils function for future stuff
@flx-sta flx-sta added the Miscellaneous Changes that don't fit under any other label label Jul 26, 2024
@Opaque02 Opaque02 changed the title Lock unlock all all at once [HOTFIX] Lock unlock all all at once Jul 26, 2024
@RedstonewolfX
Copy link
Contributor

Wait this wasn’t intentional?

@f-fsantos f-fsantos marked this pull request as ready for review July 26, 2024 15:52
@f-fsantos f-fsantos merged commit 1dac6f7 into pagefaultgames:beta Jul 26, 2024
4 checks passed
@Opaque02
Copy link
Collaborator Author

@RedstonewolfX - I was under the impression the feature itself was intentional and that this would be an emergency hotfix to be used only if it went to live and was still there, but I guess not

@Opaque02 Opaque02 deleted the delete-unlock-all branch July 27, 2024 07:03
DayKev pushed a commit to DayKev/pokerogue that referenced this pull request Jul 28, 2024
…all functionality but keeps the isBeta utils function for future stuff (pagefaultgames#3153)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Miscellaneous Changes that don't fit under any other label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants