Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor/Documentation] Beta Merge 27/07 Cleanup #3163

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

xsn34kzx
Copy link
Collaborator

@xsn34kzx xsn34kzx commented Jul 27, 2024

What are the changes?

Gathers most mentioned NITs from #3141 into one PR.

Why am I doing these changes?

Have all code suggestions under one commit rather than accepting every suggestion one by one; this also has the benefit of verifying suggestions in case of errors as a result of one or more changes.

What did change?

N/A

Screenshots/Videos

N/A

How to test the changes?

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

Co-authored-by: flx-sta <[email protected]>
Co-authored-by: torranx <[email protected]>
Co-authored-by: DustinLin <[email protected]>
@Madmadness65 Madmadness65 added the Documentation Improvements or additions to documentation label Jul 28, 2024
@Tempo-anon Tempo-anon merged commit 9ce5453 into pagefaultgames:beta Jul 29, 2024
4 checks passed
@xsn34kzx xsn34kzx deleted the beta_merge_nits branch July 29, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants