[Bug][Beta] Fix "Critical Hit" message appearing before dealing damage #4259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
The message "A critical hit!" now correctly appears after damage is dealt.
Why am I making these changes?
fixes #4251
What are the changes from a developer perspective?
field/pokemon
: The critical hit message generated inPokemon#apply
now occurs after the call toPokemon.damageAndUpdate
instead of before.Screenshots/Videos
PokeRogue.-.Google.Chrome.2024-09-14.11-04-56.mp4
How to test the changes?
MOVESET_OVERRIDE
insrc/overrides.ts
Checklist
beta
as my base branchnpm run test
)