Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Cross): [IOAPPX-343,IOAPPX-311] Add react-native-skia library + Dynamic header background (under the new Experimental Lab category)" #6103

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -448,11 +448,6 @@ PODS:
- React-Core
- react-native-screen-brightness (2.0.0-alpha):
- React
- react-native-skia (1.3.9):
- RCT-Folly (= 2021.07.22.00)
- React
- React-callinvoker
- React-Core
- react-native-slider (3.0.3):
- React
- react-native-splash-screen (3.2.0):
Expand Down Expand Up @@ -730,7 +725,6 @@ DEPENDENCIES:
- react-native-render-html (from `../node_modules/react-native-render-html`)
- react-native-safe-area-context (from `../node_modules/react-native-safe-area-context`)
- react-native-screen-brightness (from `../node_modules/react-native-screen-brightness`)
- "react-native-skia (from `../node_modules/@shopify/react-native-skia`)"
- "react-native-slider (from `../node_modules/@react-native-community/slider`)"
- react-native-splash-screen (from `../node_modules/react-native-splash-screen`)
- react-native-view-shot (from `../node_modules/react-native-view-shot`)
Expand Down Expand Up @@ -904,8 +898,6 @@ EXTERNAL SOURCES:
:path: "../node_modules/react-native-safe-area-context"
react-native-screen-brightness:
:path: "../node_modules/react-native-screen-brightness"
react-native-skia:
:path: "../node_modules/@shopify/react-native-skia"
react-native-slider:
:path: "../node_modules/@react-native-community/slider"
react-native-splash-screen:
Expand Down Expand Up @@ -1056,7 +1048,6 @@ SPEC CHECKSUMS:
react-native-render-html: 96c979fe7452a0a41559685d2f83b12b93edac8c
react-native-safe-area-context: 399a5859f6acbdf67f671c69b53113f535f3b5b0
react-native-screen-brightness: 9eefe6db96a5d757e63cdfce8e48d7c9039f2af2
react-native-skia: c06ca6074cc70bfe1ec8c45dcc82e76079805fd7
react-native-slider: e99fc201cefe81270fc9d81714a7a0f5e566b168
react-native-splash-screen: 200d11d188e2e78cea3ad319964f6142b6384865
react-native-view-shot: 4475fde003fe8a210053d1f98fb9e06c1d834e1c
Expand Down
2 changes: 1 addition & 1 deletion jest-e2e.config.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module.exports = {
preset: "react-native",
transformIgnorePatterns: [
"node_modules/(?!(jest-)?@react-native|react-native|react-navigation|@react-navigation|react-navigation-redux-helpers|react-native-device-info|rn-placeholder|jsbarcode|@pagopa/react-native-cie|react-native-share|jail-monkey|@react-native-community/art|@react-native-community/push-notification-ios|@shopify/react-native-skia|@react-native-camera-roll/camera-roll|@codler|remark|unified|bail|is-plain-obj|trough|vfile|unist-util-stringify-position|mdast-util-from-markdown|mdast-util-to-string|micromark|parse-entities|character-entities|mdast-util-to-markdown|zwitch|longest-streak|@pagopa/io-react-native-zendesk|rn-qr-generator|mixpanel-react-native|@pagopa/io-app-design-system|@sentry/react-native)"
"node_modules/(?!(jest-)?@react-native|react-native|react-navigation|@react-navigation|react-navigation-redux-helpers|react-native-device-info|rn-placeholder|jsbarcode|@pagopa/react-native-cie|react-native-share|jail-monkey|@react-native-community/art|@react-native-community/push-notification-ios|@react-native-camera-roll/camera-roll|@codler|remark|unified|bail|is-plain-obj|trough|vfile|unist-util-stringify-position|mdast-util-from-markdown|mdast-util-to-string|micromark|parse-entities|character-entities|mdast-util-to-markdown|zwitch|longest-streak|@pagopa/io-react-native-zendesk|rn-qr-generator|mixpanel-react-native|@pagopa/io-app-design-system|@sentry/react-native)"
],
moduleNameMapper: {
"\\.svg": "<rootDir>/ts/__mocks__/svgMock.js"
Expand Down
5 changes: 2 additions & 3 deletions jest.config.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
module.exports = {
preset: "react-native",
transformIgnorePatterns: [
"node_modules/(?!(jest-)?@react-native|react-native|react-navigation|@react-navigation|react-navigation-redux-helpers|react-native-device-info|rn-placeholder|jsbarcode|@pagopa/react-native-cie|react-native-share|jail-monkey|@react-native-community/art|@react-native-community/push-notification-ios|@shopify/react-native-skia|@react-native-camera-roll/camera-roll|@codler|remark|unified|bail|is-plain-obj|trough|vfile|unist-util-stringify-position|mdast-util-from-markdown|mdast-util-to-string|micromark|parse-entities|character-entities|mdast-util-to-markdown|zwitch|longest-streak|@pagopa/io-react-native-zendesk|rn-qr-generator|mixpanel-react-native|@pagopa/io-app-design-system|uuid|@sentry/react-native)"
"node_modules/(?!(jest-)?@react-native|react-native|react-navigation|@react-navigation|react-navigation-redux-helpers|react-native-device-info|rn-placeholder|jsbarcode|@pagopa/react-native-cie|react-native-share|jail-monkey|@react-native-community/art|@react-native-community/push-notification-ios|@react-native-camera-roll/camera-roll|@codler|remark|unified|bail|is-plain-obj|trough|vfile|unist-util-stringify-position|mdast-util-from-markdown|mdast-util-to-string|micromark|parse-entities|character-entities|mdast-util-to-markdown|zwitch|longest-streak|@pagopa/io-react-native-zendesk|rn-qr-generator|mixpanel-react-native|@pagopa/io-app-design-system|uuid|@sentry/react-native)"
],
moduleNameMapper: {
"\\.svg": "<rootDir>/ts/__mocks__/svgMock.js"
},
setupFiles: [
"./jestSetup.js",
"./node_modules/react-native-gesture-handler/jestSetup.js",
"./node_modules/@shopify/react-native-skia/jestSetup.js"
"./node_modules/react-native-gesture-handler/jestSetup.js"
],
globalSetup: "./jestGlobalSetup.js",
setupFilesAfterEnv: ["@testing-library/jest-native/extend-expect"],
Expand Down
5 changes: 2 additions & 3 deletions jest.config.no.timezone.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,14 @@ module.exports = {
"^.+\\.js$": "<rootDir>/node_modules/react-native/jest/preprocessor.js"
},
transformIgnorePatterns: [
"node_modules/(?!(jest-)?@react-native|react-native|react-navigation|@react-navigation|react-navigation-redux-helpers|react-native-device-info|rn-placeholder|jsbarcode|@pagopa/react-native-cie|react-native-share|jail-monkey|@react-native-community/art|@react-native-community/push-notification-ios|@shopify/react-native-skia|@react-native-camera-roll/camera-roll|@codler|remark|unified|bail|is-plain-obj|trough|vfile|unist-util-stringify-position|mdast-util-from-markdown|mdast-util-to-string|micromark|parse-entities|character-entities|mdast-util-to-markdown|zwitch|longest-streak|@pagopa/io-react-native-zendesk|rn-qr-generator|mixpanel-react-native|@pagopa/io-app-design-system|@sentry/react-native)"
"node_modules/(?!(jest-)?@react-native|react-native|react-navigation|@react-navigation|react-navigation-redux-helpers|react-native-device-info|rn-placeholder|jsbarcode|@pagopa/react-native-cie|react-native-share|jail-monkey|@react-native-community/art|@react-native-community/push-notification-ios|@react-native-camera-roll/camera-roll|@codler|remark|unified|bail|is-plain-obj|trough|vfile|unist-util-stringify-position|mdast-util-from-markdown|mdast-util-to-string|micromark|parse-entities|character-entities|mdast-util-to-markdown|zwitch|longest-streak|@pagopa/io-react-native-zendesk|rn-qr-generator|mixpanel-react-native|@pagopa/io-app-design-system|@sentry/react-native)"
],
moduleNameMapper: {
"\\.svg": "<rootDir>/ts/__mocks__/svgMock.js"
},
setupFiles: [
"./jestSetup.js",
"./node_modules/react-native-gesture-handler/jestSetup.js",
"./node_modules/@shopify/react-native-skia/jestSetup.js"
"./node_modules/react-native-gesture-handler/jestSetup.js"
],
setupFilesAfterEnv: ["@testing-library/jest-native/extend-expect"],
collectCoverage: true
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@
"@react-navigation/native": "6.1.9",
"@react-navigation/stack": "6.3.20",
"@redux-saga/testing-utils": "^1.1.3",
"@shopify/react-native-skia": "^1.3.9",
"@sentry/react-native": "^5.22.2",
"@textlint/markdown-to-ast": "^14.0.4",
"@shopify/flash-list": "~1.7.0",
Expand Down
7 changes: 0 additions & 7 deletions ts/features/design-system/DesignSystem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@ const DATA_ROUTES_DEBUG: RoutesProps = Object.values(
const DATA_ROUTES_SCREENS: RoutesProps = Object.values(
DESIGN_SYSTEM_ROUTES.SCREENS
);
const DATA_ROUTES_EXPERIMENTAL_LAB: RoutesProps = Object.values(
DESIGN_SYSTEM_ROUTES.EXPERIMENTAL_LAB
);
const DATA_ROUTES_LEGACY: RoutesProps = Object.values(
DESIGN_SYSTEM_ROUTES.LEGACY
);
Expand Down Expand Up @@ -68,10 +65,6 @@ const DESIGN_SYSTEM_SECTION_DATA: Array<SectionDataProps> = [
title: "Screens",
data: DATA_ROUTES_SCREENS
},
{
title: "Experimental Lab",
data: DATA_ROUTES_EXPERIMENTAL_LAB
},
{
title: "Debug",
data: DATA_ROUTES_DEBUG
Expand Down
234 changes: 0 additions & 234 deletions ts/features/design-system/core/DSDynamicBackground.tsx

This file was deleted.

13 changes: 0 additions & 13 deletions ts/features/design-system/navigation/navigator.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import { DSBottomSheet } from "../core/DSBottomSheet";
import { DSButtons } from "../core/DSButtons";
import { DSCards } from "../core/DSCards";
import { DSColors } from "../core/DSColors";
import { DSDynamicBackground } from "../core/DSDynamicBackground";
import { DSEdgeToEdgeArea } from "../core/DSEdgeToEdgeArea";
import { DSFooterActions } from "../core/DSFooterActions";
import { DSFooterActionsNotFixed } from "../core/DSFooterActionsNotFixed";
Expand Down Expand Up @@ -383,18 +382,6 @@ export const DesignSystemNavigator = () => {
}}
/>

{/* EXPERIMENTAL LAB */}

<Stack.Screen
name={DESIGN_SYSTEM_ROUTES.EXPERIMENTAL_LAB.DYNAMIC_BACKGROUND.route}
component={DSDynamicBackground}
options={{
headerShown: false,
headerTitle:
DESIGN_SYSTEM_ROUTES.EXPERIMENTAL_LAB.DYNAMIC_BACKGROUND.title
}}
/>

{/* HEADERS */}
<Stack.Screen
name={DESIGN_SYSTEM_ROUTES.HEADERS.FIRST_LEVEL.route}
Expand Down
1 change: 0 additions & 1 deletion ts/features/design-system/navigation/params.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ export type DesignSystemParamsList = {
[DESIGN_SYSTEM_ROUTES.DEBUG.FOOTER_ACTIONS_STICKY.route]: undefined;
[DESIGN_SYSTEM_ROUTES.DEBUG.FOOTER_ACTIONS_NOT_FIXED.route]: undefined;
[DESIGN_SYSTEM_ROUTES.DEBUG.SCREEN_END_MARGIN.route]: undefined;
[DESIGN_SYSTEM_ROUTES.EXPERIMENTAL_LAB.DYNAMIC_BACKGROUND.route]: undefined;
[DESIGN_SYSTEM_ROUTES.LEGACY.TYPOGRAPHY.route]: undefined;
[DESIGN_SYSTEM_ROUTES.LEGACY.PICTOGRAMS.route]: undefined;
[DESIGN_SYSTEM_ROUTES.LEGACY.BUTTONS.route]: undefined;
Expand Down
6 changes: 0 additions & 6 deletions ts/features/design-system/navigation/routes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,6 @@ const DESIGN_SYSTEM_ROUTES = {
title: "Footer Actions (not fixed)"
}
},
EXPERIMENTAL_LAB: {
DYNAMIC_BACKGROUND: {
route: "DS_DYNAMIC_BACKGROUND",
title: "Dynamic header background"
}
},
LEGACY: {
TYPOGRAPHY: {
route: "DESIGN_SYSTEM_LEGACY_TYPOGRAPHY",
Expand Down
Loading
Loading