Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused env vars from etl-func #157

Merged
merged 5 commits into from
Feb 28, 2025
Merged

Remove unused env vars from etl-func #157

merged 5 commits into from
Feb 28, 2025

Conversation

lucamancosu
Copy link
Collaborator

No description provided.

@lucamancosu lucamancosu requested a review from a team as a code owner February 27, 2025 13:42
Copy link

changeset-bot bot commented Feb 27, 2025

⚠️ No Changeset found

Latest commit: 10d2eb4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the etl-func A change made inside the etl-func label Feb 27, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 52.34%. Comparing base (e989c5b) to head (9ce6476).
Report is 69 commits behind head on main.

Files with missing lines Patch % Lines
apps/etl-func/src/func.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
- Coverage   52.45%   52.34%   -0.11%     
==========================================
  Files         157      164       +7     
  Lines        8036     8360     +324     
  Branches      683      707      +24     
==========================================
+ Hits         4215     4376     +161     
- Misses       3755     3915     +160     
- Partials       66       69       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acuiuli acuiuli changed the title Removed unused env vars from etl func Remove unused env vars from etl func Feb 27, 2025
Copy link
Contributor

@Garma00 Garma00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just don't merge this PR until we are done with tests

@lucacavallaro lucacavallaro changed the title Remove unused env vars from etl func Remove unused env vars from etl-func Feb 27, 2025
@lucacavallaro lucacavallaro self-requested a review February 27, 2025 16:07
Copy link
Member

@lucacavallaro lucacavallaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the infra should be updated too

@lucamancosu lucamancosu requested a review from a team as a code owner February 27, 2025 16:12
@github-actions github-actions bot added the infra label Feb 27, 2025
Copy link
Contributor

📖 Terraform Plan ('infra/resources/prod') - success

Terraform Plan
module.web_apps.module.citizen_func_autoscaler.data.azurerm_linux_function_app.this[0]: Still reading... [10s elapsed]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.web_apps.module.etl_func.azurerm_linux_function_app.this will be updated in-place
  ~ resource "azurerm_linux_function_app" "this" {
      ~ app_settings                                   = (sensitive value)
        id                                             = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-com-rg-01/providers/Microsoft.Web/sites/io-p-itn-com-etl-func-01"
        name                                           = "io-p-itn-com-etl-func-01"
        tags                                           = {
            "CostCenter"                                     = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"                                      = "Terraform"
            "Environment"                                    = "Prod"
            "ManagementTeam"                                 = "IO Comunicazione"
            "Owner"                                          = "IO"
            "Source"                                         = "https://github.com/pagopa/io-messages/blob/main/infra/resources/prod"
        }
        # (32 unchanged attributes hidden)

        # (3 unchanged blocks hidden)
    }

  # module.web_apps.module.etl_func.azurerm_linux_function_app_slot.this[0] will be updated in-place
  ~ resource "azurerm_linux_function_app_slot" "this" {
      ~ app_settings                                   = (sensitive value)
        id                                             = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-com-rg-01/providers/Microsoft.Web/sites/io-p-itn-com-etl-func-01/slots/staging"
        name                                           = "staging"
        tags                                           = {
            "CostCenter"                                     = "TS310 - PAGAMENTI & SERVIZI"
            "CreatedBy"                                      = "Terraform"
            "Environment"                                    = "Prod"
            "ManagementTeam"                                 = "IO Comunicazione"
            "Owner"                                          = "IO"
            "Source"                                         = "https://github.com/pagopa/io-messages/blob/main/infra/resources/prod"
        }
        # (30 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

Plan: 0 to add, 2 to change, 0 to destroy.

Warning: Argument is deprecated

  with module.storage_api_weu.azurerm_storage_container.message_content,
  on ../_modules/storage_accounts/storage_account_api.tf line 32, in resource "azurerm_storage_container" "message_content":
  32:   storage_account_name  = module.storage_api.name

the `storage_account_name` property has been deprecated in favour of
`storage_account_id` and will be removed in version 5.0 of the Provider.

(and 5 more similar warnings elsewhere)

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

@lucamancosu lucamancosu added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit ffd11cc Feb 28, 2025
6 checks passed
@lucamancosu lucamancosu deleted the useless-env-var branch February 28, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
etl-func A change made inside the etl-func infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants