-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused env vars from etl-func
#157
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
- Coverage 52.45% 52.34% -0.11%
==========================================
Files 157 164 +7
Lines 8036 8360 +324
Branches 683 707 +24
==========================================
+ Hits 4215 4376 +161
- Misses 3755 3915 +160
- Partials 66 69 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just don't merge this PR until we are done with tests
etl-func
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the infra should be updated too
📖 Terraform Plan ('infra/resources/prod') - successTerraform Planmodule.web_apps.module.citizen_func_autoscaler.data.azurerm_linux_function_app.this[0]: Still reading... [10s elapsed]
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# module.web_apps.module.etl_func.azurerm_linux_function_app.this will be updated in-place
~ resource "azurerm_linux_function_app" "this" {
~ app_settings = (sensitive value)
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-com-rg-01/providers/Microsoft.Web/sites/io-p-itn-com-etl-func-01"
name = "io-p-itn-com-etl-func-01"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Comunicazione"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-messages/blob/main/infra/resources/prod"
}
# (32 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
# module.web_apps.module.etl_func.azurerm_linux_function_app_slot.this[0] will be updated in-place
~ resource "azurerm_linux_function_app_slot" "this" {
~ app_settings = (sensitive value)
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-com-rg-01/providers/Microsoft.Web/sites/io-p-itn-com-etl-func-01/slots/staging"
name = "staging"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Comunicazione"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-messages/blob/main/infra/resources/prod"
}
# (30 unchanged attributes hidden)
# (2 unchanged blocks hidden)
}
Plan: 0 to add, 2 to change, 0 to destroy.
Warning: Argument is deprecated
with module.storage_api_weu.azurerm_storage_container.message_content,
on ../_modules/storage_accounts/storage_account_api.tf line 32, in resource "azurerm_storage_container" "message_content":
32: storage_account_name = module.storage_api.name
the `storage_account_name` property has been deprecated in favour of
`storage_account_id` and will be removed in version 5.0 of the Provider.
(and 5 more similar warnings elsewhere)
─────────────────────────────────────────────────────────────────────────────
Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now. |
No description provided.