fix(menu): remove negative margin to prevent horizontal scroll

[chaejunlee]

Fixes #6780

Checklist

• Includes tests
• Update documentation

Changes proposed in this pull request:

Previously in this PR #6269, menu-header (or menu-divider) had negative horizontal margin to make "dividers take up full menu width".

However this caused horizontal overflow and scroll. Removing the horizontal margin solves the scroll behavior.

Reviewers should focus on:

Previous PR doesn't really give the reason why it should have negative margin to achieve full width, while it already is taking full width.

If the negative margin was there just to make the header take the full width, negative margin is not needed and should be removed.

AS-IS

TO-BE

Screenshot

<Select /> where negative margin header is removed.

[palantirtech]

Thanks for your interest in palantir/blueprint, @chaejunlee! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

[changelog-app]

Generate changelog in packages/core/changelog/@unreleased

What do the change types mean?

• feature: A new feature of the service.
• improvement: An incremental improvement in the functionality or operation of the service.
• fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
• break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
  and external consumers of the service's API (e.g. customer-written software or integrations).
• deprecation: Advertises the intention to remove service functionality without any change to the
  operation of the service itself.
• manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
  performing database surgery, ...) at the time of upgrade for it to succeed.
• migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

• ❗The break and manual task changelog types will result in a major release!
• 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
• ✨ All others will result in a minor version release.

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

fix(menu): remove negative margin to prevent horizontal scroll

Check the box to generate changelog(s)

• Generate changelog entry

[evansjohnson]

closing in favor of #6804 which was merged - thank you for taking a stab at this!