Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle flex-expander case in tabs gap #6894

Merged
merged 6 commits into from
Sep 12, 2024
Merged

Handle flex-expander case in tabs gap #6894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2d3d5be
handle flex-expander case
evansjohnson Jul 3, 2024
74cd3ea
Add generated changelog entries
svc-changelog Jul 3, 2024
8734e28
prevent user margin-right style
evansjohnson Jul 3, 2024
39eb2c9
only vertical
evansjohnson Jul 3, 2024
939a4e2
Revert "prevent user margin-right style"
evansjohnson Jul 3, 2024
edb75ba
Update packages/core/src/components/tabs/_tabs.scss
evansjohnson Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/core/changelog/@unreleased/pr-6894.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type: fix
fix:
description: Remove extra space added after a `TabsExpander` component
links:
- https://github.com/palantir/blueprint/pull/6894
7 changes: 7 additions & 0 deletions packages/core/src/components/tabs/_tabs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,13 @@ $tab-indicator-width: 3px !default;
margin: 0;
padding: 0;
position: relative;

.#{$ns}-tabs:not(.#{$ns}-vertical) > .#{$ns}-flex-expander {
// offset column-gap from parent component above
// since flex-expander is taking up _available_ space, we don't want to add a double gap
// between the elements before and after the expander
margin-right: -$pt-grid-size * 2;
}
}

.#{$ns}-tab {
Expand Down