feat(a11y): give RadioGroup aria "radiogroup" role #6940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvandercar-vt
changed the title
ggdouglas
requested changes
Aug 21, 2024
There was a problem hiding this comment.
I'm generally supportive of the direction of this PR since it improves accessibility, but I also think we should more carefully consider how we approach the composition of the label component in the radio group.
I also support adding role="radiogroup" to the component since it should generally be there. Could you split that part of this PR out so that we can expedite getting that fixed?
bvandercar-vt
changed the title
bvandercar-vt
changed the title
ggdouglas
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Checklist
Changes proposed in this pull request:
RadioGroupcomponent should be gettingrole="radiogroup". Currently, it's just adiv. Everything else about it works in terms of a radiogroup, ie keypresses, attributes, etc.