-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Tag) No more accidentally passing active as html prop #7069
Conversation
Generate changelog in
|
@@ -73,6 +73,7 @@ export interface TagProps | |||
*/ | |||
export const Tag: React.FC<TagProps> = React.forwardRef((props, ref) => { | |||
const { | |||
active: _active, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would wrapping htmlProps
in removeNonHTMLProps
achieve the same result?
{...removeNonHTMLProps(htmlProps)}
blueprint/packages/core/src/common/props.ts
Lines 130 to 131 in 18e55c6
const INVALID_PROPS = [ | |
"active", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so, will do that too to be safe
fix(Tag) No more accidentally passing active as html propBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
CRBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
The tag saga continues, this PR prevents us from accidentally passing
active
as a prop to the tagspan