Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EntityTitle): Fill should apply 100% width #7114

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

ggdouglas
Copy link
Contributor

@ggdouglas ggdouglas commented Dec 6, 2024

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Fixes a case where EntityTitle does not take up full width when the fill={true} when it is contained within a flexbox.

By default, EntityTitle will fill the space of a non-flexbox container since it is itself a flexbox:

https://codesandbox.io/p/sandbox/entitytitle-fill-example-noflex-5f9l5x

However, when contained within a flexbox container, EntityTitle does not expand to fill the width. This is because it lacks a flex-grow or set width.

https://codesandbox.io/p/sandbox/entitytitle-fill-example-flex-7jdvmk

While this can be fixed by applying a custom class/styles, we would rather have this behavior be native to the component such that consumers don't need to apply their own styles to achieve the desired behavior. Setting width: 100% when fill is applied is also more in line with the behavior of other Blueprint components like Button, ButtonGroup, and Popover.

The fill property was originally added to EntityTitle in #6973

@changelog-app
Copy link

changelog-app bot commented Dec 6, 2024

Generate changelog in packages/core/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

fix(EntityTitle): Fill should apply 100% width

Check the box to generate changelog(s)

  • Generate changelog entry

@ggdouglas ggdouglas force-pushed the gdouglas/entity-title-fill-width branch from 2b81ed5 to 5be8942 Compare December 6, 2024 20:27
@svc-palantir-github
Copy link

Give fill entity title 100% width

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas ggdouglas merged commit 7cfe182 into develop Dec 6, 2024
12 of 14 checks passed
@ggdouglas ggdouglas deleted the gdouglas/entity-title-fill-width branch December 6, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants