Update Alignment and add new TextAlignment type
#7194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore test coverage for src/common/alignment.ts typings moduleBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
ggdouglas
force-pushed
the
gdouglas/logical-alignment
branch
from
4b70f68 to
ea75bd4
Compare
Add alignment typings file to ignored test coverageBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Add additional context for RTL support under existing typography sectionBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
jscheiny
previously approved these changes
Jan 24, 2025
LTR/RTL capitalization consistencyBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
policy-bot
bot
dismissed
jscheiny’s stale review
Invalidated by push of f971b52
Update warning messagesBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Merge branch 'develop' into gdouglas/logical-alignmentBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Update ESLint deprecation ignore statementsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
jscheiny
previously approved these changes
Feb 13, 2025
policy-bot
bot
dismissed
jscheiny’s stale review
Invalidated by push of e24b027
jscheiny
approved these changes
Feb 13, 2025
Remove remaining references to alignText="left"Build artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7193
Proposed changes:
Adds
"start"and"end"string literal values toAlignmentas part of the proposal to include logical property values in representing alignment inside of components. Also adds aTextAlignmenttype to (optionally) be used on thealignTextprop of<Button>and<ButtonGroup>components.