Add size prop to large variant components
#7234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggdouglas
changed the base branch from
gdouglas/size-prop-components
to
gdouglas/size-prop-buttons
ggdouglas
force-pushed
the
gdouglas/size-prop-large-components
branch
from
2b159f9 to
c3133a5
Compare
Add `size` to Tag componentsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
ggdouglas
force-pushed
the
gdouglas/size-prop-large-components
branch
from
c3133a5 to
7468d5a
Compare
Add `size` to Tag componentsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
jscheiny
reviewed
Feb 6, 2025
ggdouglas
force-pushed
the
gdouglas/size-prop-large-components
branch
from
7468d5a to
1531f9b
Compare
Fix size argument type in sizeClass utilityBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
jscheiny
previously approved these changes
Feb 14, 2025
packages/core/src/common/classes.ts
Outdated
| @@ -447,7 +447,7 @@ export function positionClass(position: Position | undefined) { | |||
| } | |||
|
|
|||
| export function sizeClass( | |||
| size: Size | Omit<Size, "small">, | |||
| size: Size | NonSmallSize, | |||
There was a problem hiding this comment.
This is equivalent to just Size, we can simplify this.
ggdouglas
force-pushed
the
gdouglas/size-prop-large-components
branch
from
503153e to
c322cde
Compare
policy-bot
bot
dismissed
jscheiny’s stale review
Invalidated by push of c322cde
ggdouglas
force-pushed
the
gdouglas/size-prop-large-components
branch
from
0ebbacc to
3c7c6d1
Compare
ggdouglas
force-pushed
the
gdouglas/size-prop-large-components
branch
from
3c7c6d1 to
f6716ef
Compare
Use Exclude instead of Omit for NonSmallSize typeBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Revert unintentional changes to demo-appBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
jscheiny
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7232
Proposed changes:
FLUP to #7226 that adds the
sizeprop to the following components:<Checkbox><CompoundTag><Radio><Switch><Tabs><Tag><TagInput>