Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unwarranted size deprecation console warnings #7285

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

ggdouglas
Copy link
Contributor

@ggdouglas ggdouglas commented Feb 28, 2025

Proposed changes:

Issue raised in #7232 (comment), related to #7232

Fixes deprecation warnings for newly deprecated small and large props firing where they shouldn't for components that provide defaultProps to these props (like NumericInput).

Setting these to explicitly check for true values makes the warning less effective against warning against mixed use, e.g.

<InputGroup small={true} large={false} />

but it also makes it more resilient against triggering false-positives, which seems more important.

@svc-palantir-github
Copy link

Only trigger deprecated size warning for explicitly true values

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas ggdouglas changed the title Remove unwaranted size deprecation console warnings Remove unwarranted size deprecation console warnings Feb 28, 2025
@ggdouglas ggdouglas merged commit 6bea33f into develop Feb 28, 2025
14 checks passed
@ggdouglas ggdouglas deleted the gdouglas/fix-small-large-deprecation-warnings branch February 28, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants