Add csrf_token() to Jinja2 globals #118
Merged
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installing csrf_token() in the render context only causes errors in imported Jinja2 templates. It can be avoided by explicitly importing templates with context, but it is a cognitive burden to remember which templates should be imported with context and which don't have to be.
|
Given this, you should probably remove the context processor at https://github.com/clee704/flask-wtf/blob/master/flask_wtf/csrf.py#L139 |
|
wow. This patch really sucks. It conflicts with another pull request: #112 |
|
Lol. FWIW I think the context processor is better. The macro can be solved by passing |
|
@eriktaubeneck I didn't remove the context processor because it is necessary to support templates other than Jinja2. Jinja2 globals and context processors don't have to be exclusive. |
|
It seems it's not my commit that causes tests to fail. Check out 9482767. |
|
It seems that we can keep them both. |
|
It just seemed redundant at the surface, but you have a good point with other templates. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing csrf_token() in the render context only causes errors in
imported Jinja2 templates. It can be avoided by explicitly importing
templates with context, but it is a cognitive burden to remember which
templates should be imported with context and which don't have to be.