-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TabMenu) - Adding TabMenu to UI kit (with correct rebasing) #19
Merged
hachiojidev
merged 22 commits into
pancakeswap:master
from
ChefHutch:feature/tab-bar-rebase-2
Mar 19, 2021
Merged
feat(TabMenu) - Adding TabMenu to UI kit (with correct rebasing) #19
hachiojidev
merged 22 commits into
pancakeswap:master
from
ChefHutch:feature/tab-bar-rebase-2
Mar 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e6caf40
to
46a9c1e
Compare
Closed
…on implementing tests
e4ece63
to
89cf269
Compare
hachiojidev
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a horrible rebase on the OG PR, here is the new one with the correct rebasing 🙏
Added new components to the UIKit:
Exported:
TabMenuProps, TabProps
Not exported:
Details
onClicks
set theactiveIndex
depending on the index of the child that has been clickedStyledTabMenu
is responsible for the space between the buttons, and the elements' bottom-borderStyledTab
is a styled html button, with dynamic color/background-color depending on whether it is selected. Below 572px the tab elements flex-grow to fill the available space. overflow-y is set to scroll so these elements become scrollable if they break out of the container.Questions
Tab
be separated into its own package?