Fix Style/MultilineTernaryOperator offenses

.rubocop_todo.yml

@@ -48,10 +48,3 @@ Style/ModuleFunction:
   Exclude:
     - 'lib/paper_trail/serializers/json.rb'
     - 'lib/paper_trail/serializers/yaml.rb'
-
-# Offense count: 4
-Style/MultilineTernaryOperator:
-  Exclude:
-    - 'lib/paper_trail/config.rb'
-    - 'lib/paper_trail/has_paper_trail.rb'
-    - 'lib/paper_trail/reifier.rb'

lib/paper_trail/config.rb

@@ -33,9 +33,11 @@ def serialized_attributes=(_)
     end
 
     def track_associations
-      @track_associations.nil? ?
-        PaperTrail::VersionAssociation.table_exists? :
+      if @track_associations.nil?
+        PaperTrail::VersionAssociation.table_exists?
+      else
         @track_associations
+      end
     end
     alias_method :track_associations?, :track_associations
 

lib/paper_trail/has_paper_trail.rb

@@ -221,10 +221,7 @@ def versions_between(start_time, end_time, _reify_options = {})
 
       # Returns the object (not a Version) as it was most recently.
       def previous_version
-        preceding_version = source_version ?
-          source_version.previous :
-          send(self.class.versions_association_name).last
-        preceding_version.reify if preceding_version
+        preceding_version.try(:reify)
       end
 
       # Returns the object (not a Version) as it became next.
@@ -306,6 +303,14 @@ def source_version
         send self.class.version_association_name
       end
 
+      def preceding_version
+        if source_version
+          source_version.previous
+        else
+          send(self.class.versions_association_name).last
+        end
+      end
+
       def record_create
         if paper_trail_switched_on?
           data = {

lib/paper_trail/reifier.rb

@@ -17,9 +17,7 @@ def reify(version, options)
           unversioned_attributes: :nil
         )
 
-        attrs = version.class.object_col_is_json? ?
-          version.object :
-          PaperTrail.serializer.load(version.object)
+        attrs = version.send(:object_deserialized)
 
         # Normally a polymorphic belongs_to relationship allows us to get the
         # object we belong to by calling, in this case, `item`.  However this
@@ -284,9 +282,8 @@ def reify_has_many_through(transaction_id, associations, model, options = {})
       # table, this method would return the constant `Fruit`.
       def version_reification_class(version, attrs)
         inheritance_column_name = version.item_type.constantize.inheritance_column
-        class_name = attrs[inheritance_column_name].blank? ?
-          version.item_type :
-          attrs[inheritance_column_name]
+        class_name = attrs[inheritance_column_name] || version.item_type
+
         class_name.constantize
       end
 

lib/paper_trail/version_concern.rb

@@ -269,6 +269,15 @@ def load_changeset
       {}
     end
 
+    # @api private
+    def object_deserialized
+      if self.class.object_col_is_json?
+        object
+      else
+        PaperTrail.serializer.load(object)
+      end
+    end
+
     # @api private
     def object_changes_deserialized
       if self.class.object_changes_col_is_json?