Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move OP codecs test #11536

Closed
Tracked by #7649
emhane opened this issue Oct 7, 2024 · 4 comments
Closed
Tracked by #7649

Move OP codecs test #11536

emhane opened this issue Oct 7, 2024 · 4 comments
Labels
A-op-reth Related to Optimism and op-reth C-test A change that impacts how or what we test D-complex Quite challenging from either a design or technical perspective Ask for help! S-wontfix This issue is the result of a deliberate design decision, and will not be fixed

Comments

@emhane
Copy link
Member

emhane commented Oct 7, 2024

Describe the feature

Move OP codecs test into reth-optimism-storage

reth/crates/storage/codecs/src/alloy/transaction/mod.rs

Lines 34 to 38 in 6a1ec0d

#[cfg(feature = "optimism")]
#[test]
fn test_ensure_backwards_compatibility_optimism() {
assert_eq!(TxDeposit::bitflag_encoded_bytes(), 2);
}

Additional context

No response
@emhane emhane added D-good-first-issue Nice and easy! A great choice to get started C-test A change that impacts how or what we test A-op-reth Related to Optimism and op-reth labels Oct 7, 2024
@emhane emhane mentioned this issue Oct 7, 2024
Closed
edisontim added a commit to edisontim/reth that referenced this issue Oct 7, 2024
@edisontim
enh: move codec tests
001e02e 
closes paradigmxyz#11536
@edisontim edisontim mentioned this issue Oct 7, 2024
Closed
@edisontim
Copy link
Contributor

gm @emhane, I've opened a PR for this

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 6, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Nov 6, 2024
@emhane emhane removed the S-stale This issue/PR is stale and will close with no further activity label Nov 6, 2024
@emhane emhane reopened this Nov 6, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Reth Tracker Nov 6, 2024
@emhane emhane added D-complex Quite challenging from either a design or technical perspective Ask for help! and removed D-good-first-issue Nice and easy! A great choice to get started labels Nov 6, 2024
@emhane
Copy link
Member Author

emhane commented Nov 13, 2024

won't fix #11549 (comment)

@emhane emhane closed this as completed Nov 13, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Nov 13, 2024
@emhane emhane added the S-wontfix This issue is the result of a deliberate design decision, and will not be fixed label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth C-test A change that impacts how or what we test D-complex Quite challenging from either a design or technical perspective Ask for help! S-wontfix This issue is the result of a deliberate design decision, and will not be fixed
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enh: move codec tests edisontim/reth
2 participants
@emhane @edisontim