Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework ethapiBuilder #14437

Closed
mattsse opened this issue Feb 12, 2025 · 1 comment
Closed

Rework ethapiBuilder #14437

mattsse opened this issue Feb 12, 2025 · 1 comment
Labels
A-cli Related to the reth CLI A-sdk Related to reth's use as a library C-enhancement New feature or request S-needs-design This issue requires design work to think about how it would best be accomplished

Comments

@mattsse
Copy link
Collaborator

mattsse commented Feb 12, 2025

Describe the feature

as #14421 surfaced, the way we configure the ethapi:

reth/crates/node/builder/src/rpc.rs

Lines 354 to 355 in ea40f78

/// Builder for `EthApi`
eth_api_builder: Box<dyn FnOnce(&EthApiBuilderCtx<Node>) -> EthApi + Send + Sync>,

is a bit weird

this should also be some regular trait instead

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Feb 12, 2025
@mattsse mattsse added S-needs-design This issue requires design work to think about how it would best be accomplished A-cli Related to the reth CLI A-sdk Related to reth's use as a library and removed S-needs-triage This issue needs to be labelled labels Feb 12, 2025
@emhane
Copy link
Member

emhane commented Feb 12, 2025

closing, duplicate of #12509

@emhane emhane closed this as completed Feb 12, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-cli Related to the reth CLI A-sdk Related to reth's use as a library C-enhancement New feature or request S-needs-design This issue requires design work to think about how it would best be accomplished
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattsse @emhane