Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(op, cli): add cli option to enable tx conditional #14421

Merged
merged 7 commits into from
Feb 12, 2025

Conversation

fgimenez
Copy link
Member

Closes #14201

@github-actions github-actions bot added A-op-reth Related to Optimism and op-reth A-tx-pool Related to the transaction mempool labels Feb 11, 2025
@fgimenez fgimenez added the A-cli Related to the reth CLI label Feb 11, 2025
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, smol nits

Comment on lines +210 to +217
/// Sequencer client, configured to forward submitted transactions to sequencer of given OP
/// network.
pub sequencer_client: Option<SequencerClient>,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense I think,

not quite sure yet how to configure this properly, need to check

@mattsse mattsse mentioned this pull request Feb 12, 2025
@fgimenez fgimenez force-pushed the fgimenez/tx-conditional-cli branch from 8ef5f25 to 71852a3 Compare February 12, 2025 11:40
Copy link

codspeed-hq bot commented Feb 12, 2025

CodSpeed Performance Report

Merging #14421 will not alter performance

Comparing fgimenez/tx-conditional-cli (e94c477) with main (82903d9)

Summary

✅ 77 untouched benchmarks

@fgimenez fgimenez marked this pull request as ready for review February 12, 2025 12:26
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

this is good enough for now

@fgimenez fgimenez added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit 71b9f12 Feb 12, 2025
44 checks passed
@fgimenez fgimenez deleted the fgimenez/tx-conditional-cli branch February 12, 2025 13:29
frankudoags pushed a commit to frankudoags/reth that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI A-op-reth Related to Optimism and op-reth A-tx-pool Related to the transaction mempool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cli option for enabling sendrawtxconditionals
2 participants