Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric for propagated transactions size #5846

Open
Rjected opened this issue Dec 21, 2023 · 9 comments
Open

Add metric for propagated transactions size #5846

Rjected opened this issue Dec 21, 2023 · 9 comments
Assignees
Labels
A-observability Related to tracing, metrics, logs and other observability tools A-tx-pool Related to the transaction mempool C-enhancement New feature or request

Comments

@Rjected
Copy link
Member

Rjected commented Dec 21, 2023

Describe the feature

We currently have the following metrics for transactions:

/// Metrics for the TransactionsManager
#[derive(Metrics)]
#[metrics(scope = "network")]
pub struct TransactionsManagerMetrics {
/// Total number of propagated transactions
pub(crate) propagated_transactions: Counter,

The propagated_transactions metric is useful, but does not necessarily give us insight into the network load caused by propagation. We could do that by adding a similar metric that counts the size of the propagated transactions in bytes.

Additional context

No response

@Rjected Rjected added C-enhancement New feature or request A-tx-pool Related to the transaction mempool A-observability Related to tracing, metrics, logs and other observability tools labels Dec 21, 2023
@1010adigupta
Copy link
Contributor

would like to work on this with some guidance :)

@mattsse
Copy link
Collaborator

mattsse commented Jan 18, 2024

cool, this will be possible after #6012 , merging shortly

fyi @emhane

or actually this is unrelated to #6012

fn propagate_transactions(
&mut self,
to_propagate: Vec<PropagateTransaction>,
) -> PropagatedTransactions {

@Rjected
Copy link
Member Author

Rjected commented Feb 1, 2024

@1010adigupta have you had time to work on this? do you need any help?

@ameya-deshmukh
Copy link

@Rjected I can take this up on the weekend if Adi is cool with it :)

@Rjected
Copy link
Member Author

Rjected commented Feb 1, 2024

@Rjected I can take this up on the weekend if Adi is cool with it :)

Sure, if you have time go for it!

@1010adigupta
Copy link
Contributor

@Rjected I can take this up on the weekend if Adi is cool with it :)

yeah sure you can take this up, was not able to look into it much :)

@1010adigupta 1010adigupta removed their assignment Feb 1, 2024
@emhane
Copy link
Member

emhane commented Feb 1, 2024

would be really nice if this was grouped by version (eth66 or eth68) and tx type. that can also be a separate issue though.

@onbjerg
Copy link
Collaborator

onbjerg commented Apr 29, 2024

Hey @ameya-deshmukh, any blockers here? Feel free to open a draft PR if you need feedback on direction/have questions :)

@ameya-deshmukh
Copy link

hey @onbjerg! no blockers as such but i'm still working on a wip pr. will updated by late friday/early saturday if that works. thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools A-tx-pool Related to the transaction mempool C-enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

6 participants