-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metric for propagated transactions size #5846
Comments
would like to work on this with some guidance :) |
cool, this will be possible after #6012 , merging shortly fyi @emhane or actually this is unrelated to #6012 reth/crates/net/network/src/transactions.rs Lines 331 to 334 in 663d877
|
@1010adigupta have you had time to work on this? do you need any help? |
@Rjected I can take this up on the weekend if Adi is cool with it :) |
Sure, if you have time go for it! |
yeah sure you can take this up, was not able to look into it much :) |
would be really nice if this was grouped by version (eth66 or eth68) and tx type. that can also be a separate issue though. |
Hey @ameya-deshmukh, any blockers here? Feel free to open a draft PR if you need feedback on direction/have questions :) |
hey @onbjerg! no blockers as such but i'm still working on a wip pr. will updated by late friday/early saturday if that works. thanks :) |
Describe the feature
We currently have the following metrics for transactions:
reth/crates/net/network/src/metrics.rs
Lines 56 to 61 in c066aa6
The
propagated_transactions
metric is useful, but does not necessarily give us insight into the network load caused by propagation. We could do that by adding a similar metric that counts the size of the propagated transactions in bytes.Additional context
No response
The text was updated successfully, but these errors were encountered: