-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimise TransactionFetcher #6012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some suggestions re the shared request counter.
still need to take a closer look at the TransactionFetcher, but so far I was able to follow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great!
tests are looking good.
I have a few smol suggestions and questions, but overall this was easy to follow.
The debug_asserts are also very helpful here to understand the invariants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
left last nits re docs, and an optional suggestion.
I see we have a few warn! now and I believe those are leaking into the CLI output, right @shekhirin ?
should we downgrade them to debug?
yes |
Co-authored-by: zerosnacks <[email protected]>
adds retry logic to
TransactionManager
with introducingbuffered_hashes
cache and tracks retries perTxHash
.packs eth68
GetPooledTransactions
requests with respect to size metadata for requests that go out as a consequence of processing a newly receivedNewPooledTransactionHashes
.what remains to close https://github.com/orgs/paradigmxyz/projects/1/views/13?pane=issue&itemId=38236437:
unknown_hashes
for also packing retried requests with respect to size metadatatbc