Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimise TransactionFetcher #6012

Merged
merged 68 commits into from
Jan 18, 2024
Merged

optimise TransactionFetcher #6012

merged 68 commits into from
Jan 18, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Jan 10, 2024

adds retry logic to TransactionManager with introducing buffered_hashes cache and tracks retries per TxHash.

packs eth68 GetPooledTransactions requests with respect to size metadata for requests that go out as a consequence of processing a newly received NewPooledTransactionHashes.

what remains to close https://github.com/orgs/paradigmxyz/projects/1/views/13?pane=issue&itemId=38236437:

  • storing eth68 meta data in cache alongside unknown_hashes for also packing retried requests with respect to size metadata

tbc

@emhane emhane marked this pull request as draft January 10, 2024 17:17
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions re the shared request counter.

still need to take a closer look at the TransactionFetcher, but so far I was able to follow.

@mattsse mattsse added C-enhancement New feature or request A-networking Related to networking in general labels Jan 11, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great!
tests are looking good.

I have a few smol suggestions and questions, but overall this was easy to follow.

The debug_asserts are also very helpful here to understand the invariants

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

left last nits re docs, and an optional suggestion.

I see we have a few warn! now and I believe those are leaking into the CLI output, right @shekhirin ?

should we downgrade them to debug?

@shekhirin
Copy link
Collaborator

I see we have a few warn! now and I believe those are leaking into the CLI output

yes

@emhane emhane requested a review from onbjerg as a code owner January 18, 2024 13:37
@emhane emhane added this pull request to the merge queue Jan 18, 2024
Merged via the queue into main with commit 8349cb3 Jan 18, 2024
28 checks passed
@emhane emhane deleted the emhane/optimise-tx-retrieval branch January 18, 2024 23:50
shekhirin pushed a commit that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-networking Related to networking in general C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants