Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues advancing OP Base #6036

Closed
mattsse opened this issue Jan 12, 2024 · 0 comments · Fixed by #6040
Closed

Issues advancing OP Base #6036

mattsse opened this issue Jan 12, 2024 · 0 comments · Fixed by #6040
Assignees
Labels
A-op-reth Related to Optimism and op-reth C-bug An unexpected or incorrect behavior C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jan 12, 2024

Describe the feature

newPayloadsV2 are currently being rejected with missing withdrawals after canyon update:

"{\"jsonrpc\":\"2.0\",\"error\":{\"code\":-32602,\"message\":\"Invalid params\",\"data\":{\"err\":\"withdrawals pre-Shanghai\"}},\

The bug is that OP canyon adds support for shanghai https://eips.ethereum.org/EIPS/eip-4895

https://blog.oplabs.co/canyon-hardfork/

and we reject them here:

validate_version_specific_fields(
&self.inner.chain_spec,
EngineApiMessageVersion::V2,
&payload_or_attrs,
)?;

more specifically:

EngineApiMessageVersion::V2 | EngineApiMessageVersion::V3 => {
if is_shanghai && !has_withdrawals {
return Err(AttributesValidationError::NoWithdrawalsPostShanghai)
}

because we only check for Hardfork::Shanghai:

let is_shanghai = chain_spec.fork(Hardfork::Shanghai).active_at_timestamp(timestamp);

Additional context

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Jan 12, 2024
@mattsse mattsse added C-bug An unexpected or incorrect behavior A-op-reth Related to Optimism and op-reth and removed S-needs-triage This issue needs to be labelled labels Jan 12, 2024
@clabby clabby self-assigned this Jan 12, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth C-bug An unexpected or incorrect behavior C-enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants