Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Activate shanghai with Canyon on Base Mainnet #6040

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Jan 12, 2024

Overview

Made a mobile PR to add Canyon to the Base Mainnet spec last night, missed activating Shanghai. Follow-up to #6034.

Metadata
closes #6036

@clabby clabby requested a review from gakonst as a code owner January 12, 2024 14:15
@clabby clabby requested a review from mattsse January 12, 2024 14:17
@clabby clabby changed the title fix: Activate shanghai with Canyon fix: Activate shanghai with Canyon on Base Mainnet Jan 12, 2024
@clabby clabby added the A-op-reth Related to Optimism and op-reth label Jan 12, 2024
@clabby clabby self-assigned this Jan 12, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nice this should work

fyi @Rjected we should still do #6037 I think

@clabby clabby added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit 3675c63 Jan 12, 2024
27 checks passed
@clabby clabby deleted the cl/canyon-shanghai-activation branch January 12, 2024 14:35
@Chomtana
Copy link
Contributor

Chomtana commented Jan 13, 2024

I still experience stuck on base mainnet

op-node

Jan 13 02:53:36 nc-ph-5258 op-node[4115336]: t=2024-01-13T02:53:36+0000 lvl=warn msg="Failed to share forkchoice-updated signal" state="&{HeadBlockHash:0x644389b8e38cea028fbd119807ade9da2eb25e30da79bba6313db69136cbb953 SafeBlockHash:0x644389b8e38cea028fbd119807ade9da2eb25e30da79bba6313db69136cbb953 FinalizedBlockHash:0x644389b8e38cea028fbd119807ade9da2eb25e30da79bba6313db69136cbb953}" err="Invalid params"
Jan 13 02:53:36 nc-ph-5258 op-node[4115336]: t=2024-01-13T02:53:36+0000 lvl=warn msg="Derivation process temporary error"     attempts=5 err="engine stage failed: temp: temporarily cannot insert new safe block: failed to create new block via forkchoice: unrecognized rpc error: Invalid params"

op-reth

Jan 13 03:08:46 nc-ph-5258 op-reth[4130756]: 2024-01-13T03:08:46.500802Z  INFO reth::commands::node::events: Canonical chain committed number=9140045 hash=0x644389b8e38cea028fbd119807ade9da2eb25e30da79bba6313db69136cbb953 elapsed=358.024µs
Jan 13 03:08:46 nc-ph-5258 op-reth[4130756]: 2024-01-13T03:08:46.500857Z  INFO reth::commands::node::events: Forkchoice updated head_block_hash=0x644389b8e38cea028fbd119807ade9da2eb25e30da79bba6313db69136cbb953 safe_block_hash=0x644389b8e38cea028fbd119807ade9da2eb25e30da79bba6313db69136cbb953 finalized_block_hash=0x644389b8e38cea028fbd119807ade9da2eb25e30da79bba6313db69136cbb953 status=Valid
Jan 13 03:08:51 nc-ph-5258 op-reth[4130756]: 2024-01-13T03:08:51.723872Z  INFO reth::cli: Status connected_peers=4 freelist=4561 latest_block=9140045
Jan 13 03:08:56 nc-ph-5258 op-reth[4130756]: 2024-01-13T03:08:56.545446Z  INFO blockchain_tree: Block is already canonical, ignoring. block_hash=0x644389b8e38cea028fbd119807ade9da2eb25e30da79bba6313db69136cbb953
Jan 13 03:08:56 nc-ph-5258 op-reth[4130756]: 2024-01-13T03:08:56.545553Z  INFO reth::commands::node::events: Canonical chain committed number=9140045 hash=0x644389b8e38cea028fbd119807ade9da2eb25e30da79bba6313db69136cbb953 elapsed=147.451µs
Jan 13 03:08:56 nc-ph-5258 op-reth[4130756]: 2024-01-13T03:08:56.545577Z  INFO reth::commands::node::events: Forkchoice updated head_block_hash=0x644389b8e38cea028fbd119807ade9da2eb25e30da79bba6313db69136cbb953 safe_block_hash=0x644389b8e38cea028fbd119807ade9da2eb25e30da79bba6313db69136cbb953 finalized_block_hash=0x644389b8e38cea028fbd119807ade9da2eb25e30da79bba6313db69136cbb953 status=Valid
Jan 13 03:09:06 nc-ph-5258 op-reth[4130756]: 2024-01-13T03:09:06.597284Z  INFO blockchain_tree: Block is already canonical, ignoring. block_hash=0x644389b8e38cea028fbd119807ade9da2eb25e30da79bba6313db69136cbb953
Jan 13 03:09:06 nc-ph-5258 op-reth[4130756]: 2024-01-13T03:09:06.597454Z  INFO reth::commands::node::events: Canonical chain committed number=9140045 hash=0x644389b8e38cea028fbd119807ade9da2eb25e30da79bba6313db69136cbb953 elapsed=192.202µs
Jan 13 03:09:06 nc-ph-5258 op-reth[4130756]: 2024-01-13T03:09:06.597521Z  INFO reth::commands::node::events: Forkchoice updated head_block_hash=0x644389b8e38cea028fbd119807ade9da2eb25e30da79bba6313db69136cbb953 safe_block_hash=0x644389b8e38cea028fbd119807ade9da2eb25e30da79bba6313db69136cbb953 finalized_block_hash=0x644389b8e38cea028fbd119807ade9da2eb25e30da79bba6313db69136cbb953 status=Valid

op-reth --version

reth Version: 0.1.0-alpha.14
Commit SHA: 8761072
Build Timestamp: 2024-01-13T02:24:57.880841073Z
Build Features: default,jemalloc,optimism,reth_optimism_payload_builder
Build Profile: release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues advancing OP Base
4 participants