Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffered hash not removed when received over broadcast #6315

Closed
1 task done
emhane opened this issue Jan 31, 2024 · 0 comments · Fixed by #6316
Closed
1 task done

Buffered hash not removed when received over broadcast #6315

emhane opened this issue Jan 31, 2024 · 0 comments · Fixed by #6316
Labels
A-networking Related to networking in general C-bug An unexpected or incorrect behavior

Comments

@emhane
Copy link
Member

emhane commented Jan 31, 2024

Describe the bug

known hashes are buffered.

a request to fetch transactions goes out. in the time it takes for it to resolve, we receive some of the requested hashes over full tx broadcast. this means they are removed from unknown_hashes. the request resolves. some of the requested hashes are not in the response, yet, tx fetcher attempts to buffer these for retry.

Steps to reproduce

`RUST_LOG=trace cargo run -- node --metrics "127.0.0.1:9001" --instance 2

Node logs

thread 'tokio-runtime-worker' panicked at crates/net/network/src/transactions/fetcher.rs:258:13:
`%hash` in `@buffered_hashes` that's not in `@unknown_hashes`, `@buffered_hashes` should be a subset of keys in `@unknown_hashes`, broken invariant `@buffered_hashes` and `@unknown_hashes`, ..

Platform(s)

Linux (x86), Linux (ARM), Mac (Intel), Mac (Apple Silicon), Windows (x86), Windows (ARM)

What version/commit are you on?

main

What database version are you on?

What type of node are you running?

Archive (default)

What prune config do you use, if any?

No response

If you've built Reth from source, provide the full command you used

No response

Code of Conduct

  • I agree to follow the Code of Conduct
@emhane emhane added C-bug An unexpected or incorrect behavior S-needs-triage This issue needs to be labelled labels Jan 31, 2024
@emhane emhane added A-networking Related to networking in general and removed S-needs-triage This issue needs to be labelled A-networking Related to networking in general labels Jan 31, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-networking Related to networking in general C-bug An unexpected or incorrect behavior
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant