Fix bug, rebuffer hashes that were received over broadcast #6316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
force-pushed
the
emhane/fix-bug-buffer-known-hashes
branch
from
3db0517 to
e82b284
Compare
mattsse
requested changes
Feb 1, 2024
mattsse
reviewed
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6315 and #6369 which panicked in debug mode thanks to
debug_assert.during the time a tx hash was in an inflight request, the tx could have been seen over gossip. this pr now accounts for the possibility of that occurring. it makes sure that hashes that weren't successfully fetched, aren't buffered for re-fetch. it also makes sure that when some txns are seen over gossip, they are also deleted from the re-fetch buffer.