Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Counter metric name should adhere to *_total pattern #8150

Closed
1 task done
shekhirin opened this issue May 8, 2024 · 0 comments · Fixed by #8263
Closed
1 task done

Counter metric name should adhere to *_total pattern #8150

shekhirin opened this issue May 8, 2024 · 0 comments · Fixed by #8263
Labels
A-observability Related to tracing, metrics, logs and other observability tools C-debt A clean up/refactor of existing code D-good-first-issue Nice and easy! A great choice to get started

Comments

@shekhirin
Copy link
Collaborator

shekhirin commented May 8, 2024 •
edited by emhane
Loading

Describe the feature

We have a bunch of Counter metrics that do not adhere to the recommended pattern: https://github.com/search?q=repo:paradigmxyz/reth+/.*:+Counter/+NOT+total&type=code.

We need to rename these metrics, so that they have the suffix _total and update the Grafana dashboards accordingly.

Additional context

No response

Tasks
Preview Give feedback
  1. fix(discv5): update metrics wrt unverifiable enrs #8149
    A-discv5 A-observability C-bug
@shekhirin shekhirin added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started A-observability Related to tracing, metrics, logs and other observability tools labels May 8, 2024
@shekhirin shekhirin mentioned this issue May 8, 2024
Merged
@emhane emhane added C-debt A clean up/refactor of existing code and removed C-enhancement New feature or request labels May 9, 2024
@estensen estensen mentioned this issue May 14, 2024
Merged
@vcshih vcshih mentioned this issue May 20, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker May 29, 2024
@emhane emhane mentioned this issue Jul 15, 2024
Merged
This was referenced Aug 28, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-observability Related to tracing, metrics, logs and other observability tools C-debt A clean up/refactor of existing code D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add _total suffix to counter metrics estensen/reth
2 participants
@shekhirin @emhane