chore: add _total suffix to counter metrics #8263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estensen
requested review from
mattsse,
Rjected,
onbjerg and
rkrasiuk
as code owners
estensen
commented
May 14, 2024
| @@ -405,10 +407,11 @@ impl TaskExecutor { | |||
| .in_current_span(); | |||
|
|
|||
| // Clone only the specific counter that we need. | |||
| let finished_critical_tasks_metrics = self.metrics.finished_critical_tasks.clone(); | |||
| let finished_critical_tasks_total_metrics = | |||
There was a problem hiding this comment.
should the var names here map to the metrics 1-1? they do tend to become long
|
I couldn't find any Grafana dashboards to update |
mattsse
approved these changes
May 14, 2024
onbjerg
previously requested changes
May 14, 2024
emhane
added
D-good-first-issue
DaniPopes
approved these changes
May 23, 2024
mattsse
dismissed
onbjerg’s stale review
double checked, I think I caught everything
mw2000
pushed a commit
to mw2000/reth
that referenced
this pull request
Jun 5, 2024
Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8150