Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use associated trait bound for Database Error = ProviderError #8152

Closed
mattsse opened this issue May 8, 2024 · 2 comments · Fixed by #8951
Closed

Use associated trait bound for Database Error = ProviderError #8152

mattsse opened this issue May 8, 2024 · 2 comments · Fixed by #8951
Assignees
@i-m-aditya
Labels
A-execution Related to the Execution and EVM C-enhancement New feature or request M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity

Comments

@mattsse
Copy link
Collaborator

mattsse commented May 8, 2024 •
edited
Loading

Describe the feature

reth/crates/evm/src/execute.rs

Line 144 in 8954ffb

type Executor<DB: Database<Error = ProviderError>>: for<'a> Executor<

ideally we can use something like type Executor<DB: Database<Error : Into<ProviderError>>>: instead.

This currently only works on nightly, but will be stabilized:

rust-lang/rust#52662

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-blocked This cannot more forward until something else changes A-execution Related to the Execution and EVM labels May 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label May 30, 2024
@mattsse mattsse added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels May 30, 2024
@mattsse mattsse mentioned this issue May 31, 2024
Closed
@mattsse mattsse mentioned this issue Jun 14, 2024
Closed
@mattsse mattsse removed the S-blocked This cannot more forward until something else changes label Jun 17, 2024
@i-m-aditya
Copy link
Contributor

Working on this.

@i-m-aditya i-m-aditya mentioned this issue Jun 19, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@i-m-aditya i-m-aditya

Labels
A-execution Related to the Execution and EVM C-enhancement New feature or request M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Using associated trait bound for db error i-m-aditya/reth
2 participants
@mattsse @i-m-aditya