Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate critical task metrics in grafana dashboard #8332

Closed
mattsse opened this issue May 21, 2024 · 5 comments · Fixed by #11815
Closed

Integrate critical task metrics in grafana dashboard #8332

mattsse opened this issue May 21, 2024 · 5 comments · Fixed by #11815
Assignees
Labels
A-observability Related to tracing, metrics, logs and other observability tools C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity

Comments

@mattsse
Copy link
Collaborator

mattsse commented May 21, 2024

Describe the feature

we have these useful metrics but don't have them in the dashboard:

/// Task Executor Metrics
#[derive(Metrics, Clone)]
#[metrics(scope = "executor.spawn")]
pub struct TaskExecutorMetrics {
/// Number of spawned critical tasks
pub(crate) critical_tasks: Counter,
/// Number of finished spawned critical tasks
pub(crate) finished_critical_tasks: Counter,
/// Number of spawned regular tasks
pub(crate) regular_tasks: Counter,
/// Number of finished spawned regular tasks
pub(crate) finished_regular_tasks: Counter,
}

TODO

  • integrate a graph in grafana similar to

"targets": [
{
"datasource": {
"type": "prometheus",
"uid": "${DS_PROMETHEUS}"
},
"editorMode": "builder",
"expr": "rate(reth_network_pool_transactions_messages_sent{instance=~\"$instance\"}[$__rate_interval])",
"hide": false,
"instant": false,
"legendFormat": "Tx",
"range": true,
"refId": "A"
},
{
"datasource": {
"type": "prometheus",
"uid": "${DS_PROMETHEUS}"
},
"editorMode": "builder",
"expr": "rate(reth_network_pool_transactions_messages_received{instance=~\"$instance\"}[$__rate_interval])",
"hide": false,
"legendFormat": "Rx",
"range": true,
"refId": "B"
},
{
"datasource": {
"type": "prometheus",
"uid": "${DS_PROMETHEUS}"
},
"editorMode": "code",
"expr": "reth_network_pool_transactions_messages_sent{instance=~\"$instance\"} - reth_network_pool_transactions_messages_received{instance=~\"$instance\"}",
"hide": false,
"legendFormat": "Messages in Channel",
"range": true,
"refId": "C"
}
],

needs #8263

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started A-observability Related to tracing, metrics, logs and other observability tools labels May 21, 2024
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Jun 12, 2024
Copy link
Contributor

This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 19, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jun 19, 2024
@shekhirin shekhirin added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels Jun 19, 2024
@shekhirin shekhirin reopened this Jun 19, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Reth Tracker Jun 19, 2024
@d3or
Copy link
Contributor

d3or commented Jun 21, 2024

i can take this

@greged93
Copy link
Contributor

Hey @d3or I'm down to take this if you didn't have time to work on it

@d3or
Copy link
Contributor

d3or commented Oct 17, 2024

Hey! Feel free to take it :)

@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants